feat: add journey timeline section #56
Open
+399
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pyconfhyd2026 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
RajatRajdeep
requested changes
Feb 4, 2026
| return ( | ||
| <> | ||
| <Hero /> | ||
| {isJourneyEnabled && <Journey />} |
Collaborator
There was a problem hiding this comment.
There are already multiple sections in home page. Could you?
- Create an About page and add following:
- About PyConf
- Events Over the Years
- Epic Frames
| import { useEffect, useRef, useState } from 'react'; | ||
| import { Heading, Paragraph, Span } from '@/components/Typography'; | ||
|
|
||
| const journeyData = [ |
Collaborator
There was a problem hiding this comment.
Move this to data repository?
Can we use pastEditions data and add additional attributes required for this to reduce dupes.
| <section | ||
| ref={sectionRef} | ||
| id="journey" | ||
| className="scroll-mt-20 py-16 bg-sky-100 dark:bg-gray-800 overflow-hidden" |
Collaborator
There was a problem hiding this comment.
The background of the component is not consistent with website for both Dark and Light mode
RajatRajdeep
requested changes
Feb 4, 2026
Collaborator
RajatRajdeep
left a comment
RajatRajdeep
left a comment
There was a problem hiding this comment.
There are multiple accessibility issue. Kindly fix
Collaborator
|
PR checks in description are not marked as complete. Kindly check and mark them as complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue Link:
PR Checks:
make pre-pushcommand).make pre-pushcommand).