Fix: Prevent theme flicker on initial render#135
Open
pandaabinash99 wants to merge 5 commits intoHydPy:mainfrom
Open
Fix: Prevent theme flicker on initial render#135pandaabinash99 wants to merge 5 commits intoHydPy:mainfrom
pandaabinash99 wants to merge 5 commits intoHydPy:mainfrom
Conversation
| className="p-2 rounded-full hover:bg-gray-100 dark:hover:bg-gray-700" | ||
| aria-label="Toggle theme" | ||
| > | ||
| <Icon name="Moon" size={24} className="text-gray-800" /> |
Collaborator
There was a problem hiding this comment.
When the application is reloaded while already in Dark Mode, the Moon icon briefly appears before switching to the Sun icon.
Ideally, the Sun icon should be displayed immediately.
Collaborator
There was a problem hiding this comment.
The build is failing locally, could you check and confirm?
Command: npm run build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This update ensures the correct theme (light/dark) is applied before the first paint, preventing the flicker that occurred during initial page load.
Issue Link:
Fixes #32
PR Checks:
make pre-pushcommand).make pre-pushcommand).