Enhance ENVITE setup process with runtime information integration#25
Merged
Enhance ENVITE setup process with runtime information integration#25
Conversation
Contributor
avivpxi
commented
Jun 18, 2025
avivpxi
commented
- Updated network and component logic to utilize runtime information for hostname and network latency.
- Modified validation and update functions to reflect changes in the hosts file with dynamic hostname.
- Improved user messages in setup files to include runtime-specific details for better clarity during initial setup.
- Add wait time for Colima container start to allow network binding to kick in.
- Updated network and component logic to utilize runtime information for hostname and network latency. - Modified validation and update functions to reflect changes in the hosts file with dynamic hostname. - Improved user messages in setup files to include runtime-specific details for better clarity during initial setup. - Add wait time for Colima container start to allow network binding to kick in.
Tamir-Mosh
approved these changes
Jun 18, 2025
- Introduced a new runtime entry for Colima, including its socket path, internal hostname, and network latency. - Updated the fallback behavior in the runtime detection function to return a default 'Unknown' runtime when no matches are found.
- Added RuntimeInfo field to Component and Network types to enhance runtime-specific functionality. - Updated newComponent and NewNetwork functions to accept RuntimeInfo, improving the handling of network latency and internal hostnames. - Refactored Start method in Component to utilize the new RuntimeInfo field for network latency management.
Tamir-Mosh
approved these changes
Jun 19, 2025
- Improved error handling with error wrapping to provide better error messages - Updated changeslog and readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.