Skip to content

Conversation

@dduric
Copy link
Collaborator

@dduric dduric commented May 6, 2018

No description provided.

@dduric dduric self-assigned this May 6, 2018
@dduric dduric requested a review from jleclanche May 6, 2018 07:35
@dduric dduric force-pushed the LiveLogParser branch 2 times, most recently from 2286f11 to c55b4ec Compare May 6, 2018 08:54
@dduric dduric force-pushed the LiveLogParser branch 5 times, most recently from f344637 to e8bd1fe Compare May 7, 2018 13:24
@dduric dduric force-pushed the LiveLogParser branch 3 times, most recently from aee2c60 to 3fb01bc Compare May 8, 2018 15:59
@muyufan
Copy link

muyufan commented Jul 26, 2021

@dduric live parser is very useful feature, but why this isn't merged, not working?

@Ubica
Copy link

Ubica commented Jul 27, 2021

@dduric live parser is very useful feature, but why this isn't merged, not working?

@muyufan I worked on this 3 years ago. It's working up to a certain point, but I didn't have time to continue working on it as I got a full time job.
I believe jleclanche asked for tests to be written before merging it into the master branch or something on those lines.

I could revisit it and checkout if everything still works with the latest Hearthstone version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants