Open
Conversation
Alias !whois.set to !whois.setdefault and add !whois.setlocal. Also alias !whois.unset to !whois.unsetdefault and add !whois.unsetlocal
Pedantic change to be consistent.
LordAro
requested changes
Jun 30, 2018
Member
|
Related #66 |
This change makes !set always succeed in setting the whois for this channel, but it will now never over-write the global value if one exists. It also means that !unset behaves similarly, it always succeeds in unsetting whichever whois was set for the channel, including removing the global one should it exist. I think more work needs to be done to decide whether that last decision is a good one: removing/setting global data on accident is bad UX but it's better than what we currently have, and better than unexpectedly being unable to set the whois.
LordAro
approved these changes
Jul 2, 2018
LordAro
approved these changes
Jul 2, 2018
Member
LordAro
left a comment
LordAro
left a comment
There was a problem hiding this comment.
I guess I'm ok with this, though I think it could be confusing...
Member
|
Needs a small amount of rewriting for new test style |
Member
|
@bensimner branch needs a rebase (and probably a further one after #142 is merged) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alias !whois.set to !whois.setdefault and add !whois.setlocal.
Also alias !whois.unset to !whois.unsetdefault and add !whois.unsetlocal
This PR also adds useful !help text for the commands in the whois plugin.