Open
Conversation
alanbriolat
reviewed
Apr 6, 2017
Closed
LordAro
previously requested changes
Jun 26, 2018
Member
|
Ha, f-strings. Are we ready to drop py3.4 & 3.5 yet? |
Member
|
Well we dropped py3.4... @bensimner any chance of an update? ;) |
Adds extra commands: - !quote <nick> [<pattern>] - !quote.list [<pattern>] # on a channel - !qote.list <channel> [<pattern>] # in a privmsg - !quote.remove <id> [, <id>]*
Also adds `!quotes * <pattern>`, for channel-wide quoting.
Does some re-naming !quote -> !remember and !quotes -> !quote, also limits the use of !quote.list and !quote.remove to only authenticated users with the correct permissions.
Also adds tests for the formatter
Each @command is now a dispatch to a simpler function based off a regexp cli definition. This could probably be formalised into a @command.group() decorator or something later.
Moving all the quote data into an attrs class makes it easier to work with over a dictionary. Then hiding the database implementation as a mixin made the plugin class itself easier to understand.
I'm not 100% sure what this was doing. I think we don't need it anymore.
bensimner
force-pushed
the
quote-plugin
branch
from
72f5f4f to
02af8e9
Compare
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 75.85% 76.36% +0.50%
==========================================
Files 28 29 +1
Lines 2990 3194 +204
Branches 501 549 +48
==========================================
+ Hits 2268 2439 +171
- Misses 652 672 +20
- Partials 70 83 +13
Continue to review full report at Codecov.
|
alanbriolat
dismissed
LordAro’s stale review
All conversations in this review already resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a quote plugin with these commands:
(all commands are channel-specific)
remember <nick> [<pattern>]NOTICEs the user that !remember'd with a confirmation it was rememberedquote [<nick> [<pattern>]]*which is channel-wide quotingquote.remove <id> [, <id>]*quote.list [<pattern>]quote.list <channel> [<pattern>]Closes #100