Conversation
fengli79
suggested changes
Nov 8, 2024
| public enum Attr { | ||
| STATUS("grpc.status"), | ||
| METHOD("grpc.method"), | ||
| METHOD_TYPE("grpcgcp.method_type"), |
Contributor
There was a problem hiding this comment.
Please remove, I'd like to start from the bare minimum set of labels and we don't need the method_type at this moment.
| STATUS("grpc.status"), | ||
| METHOD("grpc.method"), | ||
| METHOD_TYPE("grpcgcp.method_type"), | ||
| TRANSPARENT_RETRY("grpcgcp.tr_retry"); |
Contributor
There was a problem hiding this comment.
Same for transparent retry.
| * attributes provide additional context about the metric being recorded. For example, STATUS | ||
| * represents the gRPC status code, METHOD represents the gRPC method name, and so on. | ||
| */ | ||
| public enum Attr { |
Contributor
There was a problem hiding this comment.
Please align with OpenTelemetry concepts for the naming, using Label instead of Attr.
| * Kind (e.g., COUNTER, HISTOGRAM), an internal Unit (e.g., NANOSECONDS, OCCURENCES), and a | ||
| * default MetricConfig. | ||
| */ | ||
| public enum Metric implements ConfigurableMetric { |
Contributor
There was a problem hiding this comment.
Could you help to check https://github.com/grpc/grpc-java/tree/master/opentelemetry and re-architect the implementation in a similar way?
We don't need to define our own model which forks the opentelemetry concepts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional metrics provided via GcpMetricsInterceptor.
This does not address comments to the design yet -- will be updated in the next PR.