[spark-rapids] generate spark-rapids/spark-rapids.sh from template#1284
Draft
cjac wants to merge 125 commits intoGoogleCloudDataproc:mainfrom
Draft
[spark-rapids] generate spark-rapids/spark-rapids.sh from template#1284cjac wants to merge 125 commits intoGoogleCloudDataproc:mainfrom
cjac wants to merge 125 commits intoGoogleCloudDataproc:mainfrom
Conversation
Contributor
Author
|
/gcbrun |
11 similar comments
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
okay, that brings the new code up to the standard of the previous code. Now let's start enabling more tests... |
Contributor
Author
|
/gcbrun |
3 similar comments
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
okay so now we have some rocky8 and rocky9 coverage. I don't think we have to disable the 2.0 images. Let's verify... |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
okay, now it:
Let's try skipping fewer tests still |
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
Author
|
/gcbrun |
Contributor
Author
|
I think we've got single node clusters working fine on rocky again. |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
can we skip no tests? |
Contributor
Author
|
/gcbrun |
3 similar comments
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
rebase onto new master commit |
Contributor
Author
|
/gcbrun |
* include version in action generator
cjac
force-pushed
the
spark-rapids-template-20241225
branch
from
812a3b6 to
e21f9b9
Compare
Contributor
Author
|
I'm about to run some tests |
Contributor
Author
|
/gcbrun |
cjac
force-pushed
the
spark-rapids-template-20241225
branch
from
e21f9b9 to
93bf9ec
Compare
Contributor
Author
|
/gcbrun |
cjac
force-pushed
the
spark-rapids-template-20241225
branch
2 times, most recently
from
3ca9c84 to
1d790be
Compare
Contributor
Author
|
/gcbrun |
cjac
force-pushed
the
spark-rapids-template-20241225
branch
from
1d790be to
40b2de2
Compare
Contributor
Author
|
/gcbrun |
cjac
force-pushed
the
spark-rapids-template-20241225
branch
from
40b2de2 to
fce5350
Compare
Contributor
Author
|
/gcbrun |
spark-rapids/mig.sh, spark-rapids/spark-rapids.sh: * no longer tracking generated action spark-rapids/test_spark_rapids.py: * using default machine type of n1-highmem-8 * de-duplicating shell command * perform two tests on one cluster instead of one test on two templates/spark-rapids/mig.sh.in, templates/spark-rapids/spark-rapids.sh.in: * these templates include only the code unique to these actions
cjac
force-pushed
the
spark-rapids-template-20241225
branch
from
fce5350 to
55ab2c7
Compare
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-implementation of the script using templates created while re-factoring common code under gpu/, dask/, rapids/, spark-rapids/, horovod/, mlvm/ and many of the other initialization actions.
For templates used to generate the new spark-rapids.sh and mig.sh PTAL at
https://github.com/GoogleCloudDataproc/initialization-actions/pull/1282/files#diff-9887ca799a0fd5f78f754eb371e1f771c3e80d5abc06ee6d17d54fd2ad2962a3