Skip to content

Changes Requested for Blender Extensions Reviewer#14

Merged
GoodPie merged 6 commits intomasterfrom
blender-add-on-reqs
Feb 4, 2026
Merged

Changes Requested for Blender Extensions Reviewer#14
GoodPie merged 6 commits intomasterfrom
blender-add-on-reqs

Conversation

@GoodPie
Copy link
Owner

@GoodPie GoodPie commented Feb 4, 2026

Description

Changes were requested here:
https://extensions.blender.org/approval-queue/modular-tree/#activity-14694

This includes:

  • Package extensions separately per OS
  • Remove 3D View tag
  • Ignore files

@GoodPie GoodPie self-assigned this Feb 4, 2026
Copilot AI review requested due to automatic review settings February 4, 2026 12:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses reviewer feedback for the Modular Tree Blender extension by implementing platform-specific packaging, removing an invalid tag, and excluding backup files from the build.

Changes:

  • Updated packaging to generate separate extension files per platform using Blender CLI
  • Removed "3D View" tag from the manifest
  • Added ignore patterns to exclude .blend1 backup files and __pycache__ directories

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
blender_manifest.toml Removed "3D View" tag and bumped version to 5_3_1
VERSION Incremented version from 5_3_0 to 5_3_1
.github/workflows/CD.yml Added macOS x64 build target, installed Blender CLI, and switched to split-platform packaging
.github/scripts/setup_addon.py Added ignore patterns for backup files and new --no-zip flag to support Blender CLI packaging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 113 to 115
sudo apt-get update
sudo apt-get install -y snapd
sudo snap install blender --classic
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing Blender via snap in the CI pipeline may be unreliable or slow. Consider using an official Blender binary download or a Docker image for more deterministic builds and faster execution.

Suggested change
sudo apt-get update
sudo apt-get install -y snapd
sudo snap install blender --classic
set -e
BLENDER_VERSION="4.2.0"
BLENDER_TAR="blender-${BLENDER_VERSION}-linux-x64.tar.xz"
BLENDER_URL="https://download.blender.org/release/Blender4.2/${BLENDER_TAR}"
mkdir -p "$HOME/blender"
curl -L "$BLENDER_URL" -o "$HOME/blender/$BLENDER_TAR"
tar -xJf "$HOME/blender/$BLENDER_TAR" -C "$HOME/blender"
sudo ln -s "$HOME/blender/blender-${BLENDER_VERSION}-linux-x64/blender" /usr/local/bin/blender

Copilot uses AI. Check for mistakes.
run: ls -la tmp/*.zip
- uses: actions/upload-artifact@v6
with:
name: modular_tree_extension
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact name remains singular ('modular_tree_extension') despite now uploading multiple platform-specific zip files. Consider renaming to 'modular_tree_extensions' or 'modular_tree_platform_builds' to reflect the new multi-platform output.

Copilot uses AI. Check for mistakes.

# Copy addon files
# Copy addon files (excluding backup files like .blend1)
ignore_patterns = shutil.ignore_patterns("*.blend1", "__pycache__")
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ignore_patterns variable is defined but only used when copying directories (ADDON_SOURCE_DIRNAME, RESOURCES_DIRNAME). Files like .blend1 at the root level won't be filtered. Consider applying the same pattern when copying individual files or clarify that this only applies to directories.

Copilot uses AI. Check for mistakes.
@GoodPie GoodPie merged commit 1a8ada2 into master Feb 4, 2026
12 of 13 checks passed
@GoodPie GoodPie deleted the blender-add-on-reqs branch February 4, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant