Changes Requested for Blender Extensions Reviewer#14
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses reviewer feedback for the Modular Tree Blender extension by implementing platform-specific packaging, removing an invalid tag, and excluding backup files from the build.
Changes:
- Updated packaging to generate separate extension files per platform using Blender CLI
- Removed "3D View" tag from the manifest
- Added ignore patterns to exclude
.blend1backup files and__pycache__directories
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| blender_manifest.toml | Removed "3D View" tag and bumped version to 5_3_1 |
| VERSION | Incremented version from 5_3_0 to 5_3_1 |
| .github/workflows/CD.yml | Added macOS x64 build target, installed Blender CLI, and switched to split-platform packaging |
| .github/scripts/setup_addon.py | Added ignore patterns for backup files and new --no-zip flag to support Blender CLI packaging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/CD.yml
Outdated
| sudo apt-get update | ||
| sudo apt-get install -y snapd | ||
| sudo snap install blender --classic |
There was a problem hiding this comment.
Installing Blender via snap in the CI pipeline may be unreliable or slow. Consider using an official Blender binary download or a Docker image for more deterministic builds and faster execution.
| sudo apt-get update | |
| sudo apt-get install -y snapd | |
| sudo snap install blender --classic | |
| set -e | |
| BLENDER_VERSION="4.2.0" | |
| BLENDER_TAR="blender-${BLENDER_VERSION}-linux-x64.tar.xz" | |
| BLENDER_URL="https://download.blender.org/release/Blender4.2/${BLENDER_TAR}" | |
| mkdir -p "$HOME/blender" | |
| curl -L "$BLENDER_URL" -o "$HOME/blender/$BLENDER_TAR" | |
| tar -xJf "$HOME/blender/$BLENDER_TAR" -C "$HOME/blender" | |
| sudo ln -s "$HOME/blender/blender-${BLENDER_VERSION}-linux-x64/blender" /usr/local/bin/blender |
| run: ls -la tmp/*.zip | ||
| - uses: actions/upload-artifact@v6 | ||
| with: | ||
| name: modular_tree_extension |
There was a problem hiding this comment.
The artifact name remains singular ('modular_tree_extension') despite now uploading multiple platform-specific zip files. Consider renaming to 'modular_tree_extensions' or 'modular_tree_platform_builds' to reflect the new multi-platform output.
|
|
||
| # Copy addon files | ||
| # Copy addon files (excluding backup files like .blend1) | ||
| ignore_patterns = shutil.ignore_patterns("*.blend1", "__pycache__") |
There was a problem hiding this comment.
The ignore_patterns variable is defined but only used when copying directories (ADDON_SOURCE_DIRNAME, RESOURCES_DIRNAME). Files like .blend1 at the root level won't be filtered. Consider applying the same pattern when copying individual files or clarify that this only applies to directories.
Description
Changes were requested here:
https://extensions.blender.org/approval-queue/modular-tree/#activity-14694
This includes:
3D Viewtag