[CHA-1610] Add support channels batch update #188
+499
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelmf3
requested review from
JimmyPettersson85,
nijeesh-stream,
shaljam,
totalimmersion and
vishalnarkhede
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
spec/channel_batch_updater_spec.rb
Outdated
Comment on lines
7
to
19
| def loop_times(times) | ||
| loop do | ||
| begin | ||
| yield() | ||
| return | ||
| rescue StandardError, RSpec::Expectations::ExpectationNotMetError | ||
| raise if times.zero? | ||
| end | ||
|
|
||
| sleep(1) | ||
| times -= 1 | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
I might be missing something, but Ruby already has this built in. Would it make sense to use:
10.times do |i|
# do something
endif you need exception handling this will also work
10.times do |i|
# do something
rescue => e
# handle exception
endIt would keep this a bit simpler.
Comment on lines
+26
to
+54
| def wait_for_task(task_id, timeout_seconds: 120) | ||
| sleep(2) # Initial delay | ||
|
|
||
| timeout_seconds.times do |i| | ||
| task = fetch_task_with_retry(task_id, i) | ||
| next if task.nil? | ||
|
|
||
| expect(task['task_id']).to eq(task_id) | ||
|
|
||
| case task['status'] | ||
| when 'waiting', 'pending', 'running' | ||
| sleep(1) | ||
| when 'completed' | ||
| return task | ||
| when 'failed' | ||
| # If result is empty, continue polling (matches Go behavior) | ||
| result = task['result'] | ||
| if result.nil? || (result.is_a?(Hash) && result.empty?) | ||
| sleep(2) | ||
| elsif rate_limit_error?(task) | ||
| sleep(2) | ||
| else | ||
| raise "Task failed with result: #{task['result']}" | ||
| end | ||
| end | ||
| end | ||
|
|
||
| raise "Task did not complete within #{timeout_seconds} seconds" | ||
| end |
Contributor
There was a problem hiding this comment.
📝 [rubocop] <Metrics/CyclomaticComplexity> reported by reviewdog 🐶
Cyclomatic complexity for wait_for_task is too high. [9/7]
Comment on lines
+45
to
+48
| elsif rate_limit_error?(task) | ||
| sleep(2) | ||
| else | ||
| raise "Task failed with result: #{task['result']}" |
Contributor
There was a problem hiding this comment.
Duplicate branch body detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
https://linear.app/stream/issue/CHA-1610/ruby
CLA
Description of the pull request