BREAKING: Raise GMTRequiredParameterError/GMTConflictParameterError exception for invalid values. Previously raise #3707 #4370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nput.Migrate some files.
Member
|
@Chuan1937 Thanks for your work on this! There's actually a similar PR at #4003 that takes a different approach. It would be great to compare the two implementations, decide on the best path forward, and then combine efforts accordingly. |
Contributor
Author
ok,I'll do it. |
3 tasks
Member
|
Duplicate of PR #4003. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #3707
This PR adds a new parameter exception class, GMTParameterError, and its subclasses for reporting parameter-related errors.
The error message format is:
Missing required parameter: {parameters}. Explain the reason.Conflicting parameters: {parameters}. Explain the reason.