Fixed javadoc annoyance in maven. Added preencoded opus unit test. Fixed small bug with int to obj key selection.#41
Open
mondain wants to merge 3 commits intoGagravarr:masterfrom
Open
Fixed javadoc annoyance in maven. Added preencoded opus unit test. Fixed small bug with int to obj key selection.#41mondain wants to merge 3 commits intoGagravarr:masterfrom
mondain wants to merge 3 commits intoGagravarr:masterfrom
Conversation
mondain
commented
Oct 28, 2020
| @@ -51,15 +53,15 @@ public int getNumberOfSamples() { | |||
|
|
|||
| private void calculateStructure() { | |||
| byte[] d = getData(); | |||
Author
There was a problem hiding this comment.
This was the bug exposed in the opus writer test
mondain
commented
Oct 28, 2020
| @@ -413,7 +468,15 @@ public void close() throws IOException { | |||
| for (AudioVisualDataAndSid avData : writtenPackets) { | |||
| OggPacketWriter avw = w; | |||
| if (avData.sid != sid) { | |||
Author
There was a problem hiding this comment.
This was the issue with int to object key matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.