Fix compressed to compressed texture conversion leaving leaked memory and threads#335
Open
metallicafan212 wants to merge 3 commits intoGPUOpen-Tools:masterfrom
Open
Fix compressed to compressed texture conversion leaving leaked memory and threads#335metallicafan212 wants to merge 3 commits intoGPUOpen-Tools:masterfrom
metallicafan212 wants to merge 3 commits intoGPUOpen-Tools:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue I noticed when converting one compressed texture format to another. After the conversion was done, my CPU would still be running at 100% with the Compressonator threads eating all my CPU time.
Specifically: the block that deals with compressed -> compressed only frees the buffers/codecs/threads when there's an error, but did not if the conversion was successful.