fix: remove dead UserInited handling from BTC tx monitor#362
Open
VolodymyrBg wants to merge 1 commit intoGOATNetwork:devfrom
Open
fix: remove dead UserInited handling from BTC tx monitor#362VolodymyrBg wants to merge 1 commit intoGOATNetwork:devfrom
VolodymyrBg wants to merge 1 commit intoGOATNetwork:devfrom
Conversation
eigmax
force-pushed
the
dev
branch
3 times, most recently
from
72b5e85 to
0a842a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instance_btc_tx_monitorwas includingUserInitedinstances and had aUserInitedmatch arm that never advanced the status and never triggered discard logic, always logging a warning with aNonetxid.The transition
UserInited→CommitteesAnsweredis already correctly handled ininstance_window_expiration_monitor,so this extra handling in the BTC monitor was dead and misleading.