Skip to content

feat: Add new meshes for the tests and implemente the missing one for the post-processing filter#214

Merged
paloma-martinez merged 9 commits intomainfrom
RomainBaville/feat/AddTheMissingTestForThePostProcessingFilter
Feb 3, 2026
Merged

feat: Add new meshes for the tests and implemente the missing one for the post-processing filter#214
paloma-martinez merged 9 commits intomainfrom
RomainBaville/feat/AddTheMissingTestForThePostProcessingFilter

Conversation

@RomainBaville
Copy link
Contributor

@RomainBaville RomainBaville commented Jan 26, 2026

This PR aims to harmonize the post-processing filter tests:

  • Add new meshes to test the filters
  • Implement the missing tests of post-processing filter (GeosBlockMerge, GeomechanicsCalculator)
  • Update and clean the existing test to use the new meshes

This PR close #215

@RomainBaville RomainBaville self-assigned this Jan 26, 2026
@RomainBaville RomainBaville changed the title feat: Add new meshes for filters test and implemented the missing one for the post-processing filter feat: Add new meshes for the tests and implemente the missing one for the post-processing filter Jan 26, 2026
@RomainBaville RomainBaville marked this pull request as ready for review January 27, 2026 09:41
Copy link
Collaborator

@paloma-martinez paloma-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, just a few suggestions

@@ -0,0 +1,6 @@
Those meshes used for testing post-processing filters came from a GEOS simulation with the version of the 27th November 2025.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit number would be more relevant than day.

Those meshes used for testing post-processing filters came from a GEOS simulation with the version of the 27th November 2025.
The XML-files used to launch the simulation came from the integrated tests of GEOS: singlePhasePoromechanics_FaultModel_well_seq_smoke.xml located [here](https://github.com/GEOS-DEV/GEOS/tree/develop/inputFiles/poromechanicsFractures)

The ParaView plugin "PVGeosBlockExtractAndMerge" has been use to get the vtm with the block "CellElementRegion"from the simulation pvd result. The integrated ParaView plugin "merge block" has been use to get a vtu with the data of the second time step.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The ParaView plugin "PVGeosBlockExtractAndMerge" has been use to get the vtm with the block "CellElementRegion"from the simulation pvd result. The integrated ParaView plugin "merge block" has been use to get a vtu with the data of the second time step.
The ParaView plugin "PVGeosBlockExtractAndMerge" has been used to get the vtm with the block "CellElementRegion" from the simulation pvd result. The integrated ParaView plugin "merge block" has been used to get a vtu with the data of the second time step.

@paloma-martinez paloma-martinez merged commit 59502a8 into main Feb 3, 2026
54 checks passed
@paloma-martinez paloma-martinez deleted the RomainBaville/feat/AddTheMissingTestForThePostProcessingFilter branch February 3, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add meshes and missing tests for post-processing filters

2 participants