Skip to content

feat: Add missing tests for array helpers #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paloma-martinez merged 24 commits into from
Feb 3, 2026
Merged

feat: Add missing tests for array helpers #208

paloma-martinez merged 24 commits into from
Feb 3, 2026

Conversation

@RomainBaville
Copy link
Contributor

@RomainBaville RomainBaville commented Dec 29, 2025 •
edited
Loading

This PR amis to:

  • Implement tests for all the arrayHelpers functions
  • Remove duplicated functions

This PR close #209

@RomainBaville
Add tests for hasArray
d63e937
@RomainBaville
implement checkValidValuesInMultiBlock tests
c972a72
@RomainBaville
Remove getFieldType function, vtkObject.GetClassName() does the same
562b847
@RomainBaville
Remove getArrayByName, vtkObject.GetArray does the same
e498409
@RomainBaville
Add getArrayNames tests
49de7cd
@RomainBaville
Remove getCopyArrayByName, it is unused and the functions copy and ge…
2127f76 
…tArray already exist
@RomainBaville
Add getNumpyGlobalIdsArray tests
0e75f3a
@RomainBaville
Add getNumpyArrayByName tests
a61504e
@RomainBaville
Remove getArrayNames, getAttributeSet does the same and add getAttrib…
6e968fb 
…uteSet tests
@RomainBaville
Add isAttributeInObject tests
d5787d9
@RomainBaville
Add getVtkArrayTypeInObject tests
34cc0ca
@RomainBaville
add getNumberOfComponents tests
e232c15
@RomainBaville
Add sortArrayByGlobalIds tests
16a8a69
@RomainBaville
Remove sortArrayByGlobalIds, implemented in the function getNumpyArra…
8e4f286 
…yByName
@RomainBaville
Add computeCellCenterCoordinates tests
8cf3e26
@RomainBaville
Clean for CI
2d54b57
@RomainBaville RomainBaville self-assigned this Dec 29, 2025
@RomainBaville RomainBaville added flag: ready for review type: feature type: cleanup test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI labels Dec 29, 2025
@RomainBaville RomainBaville marked this pull request as draft December 30, 2025 09:06
@RomainBaville RomainBaville marked this pull request as ready for review December 30, 2025 11:28
paloma-martinez
paloma-martinez reviewed Jan 9, 2026
View reviewed changes
RomainBaville and others added 2 commits January 22, 2026 14:24
@RomainBaville @paloma-martinez
Apply Paloma's suggestions
49ee9fd 
Co-authored-by: paloma-martinez <104762252+paloma-martinez@users.noreply.github.com>
@RomainBaville
remove capital in the variable name
502b663
paloma-martinez
paloma-martinez requested changes Feb 2, 2026
View reviewed changes
@paloma-martinez paloma-martinez merged commit bc64660 into main Feb 3, 2026
56 checks passed
@paloma-martinez paloma-martinez deleted the RomainBaville/feature/AddMissingTestsForArrayHelpers branch February 3, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paloma-martinez paloma-martinez paloma-martinez approved these changes

@jafranc jafranc Awaiting requested review from jafranc

Assignees

@RomainBaville RomainBaville

Labels

flag: ready for review test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI type: cleanup type: feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add missing tests for arrayHelpers functions

2 participants

@RomainBaville @paloma-martinez