Skip to content

fix: fix early call to calculateElementGeometricQuantities#3965

Open
bd713 wants to merge 1 commit intodevelopfrom
fix/bd713/geomComp
Open

fix: fix early call to calculateElementGeometricQuantities#3965
bd713 wants to merge 1 commit intodevelopfrom
fix/bd713/geomComp

Conversation

@bd713
Copy link
Contributor

@bd713 bd713 commented Feb 5, 2026

Background

PR #3359 moved calculateElementGeometricQuantities earlier in the mesh initialization to make fracture element centers available during well perforation processing.

Problem

However, this function computes not only centers but also volumes and surface areas, which require accessing neighbor element information that is only available after ghost exchange.

Calling this function prior ghosting can lead to crashes when bounds checking is enable

Changes

Split geometry calculation for FaceElementSubRegion into two stages:

  1. Before ghosting: Only compute element centers (satisfies well perforation requirements from PR feat: Add functions to connect well perforation to surface elements #3359)
  2. After ghosting: Compute full geometric quantities (areas, volumes) with valid neighbor information

@bd713 bd713 self-assigned this Feb 5, 2026
@bd713 bd713 added the type: bug Something isn't working label Feb 7, 2026
@bd713 bd713 marked this pull request as ready for review February 7, 2026 22:12
@bd713 bd713 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs labels Feb 8, 2026
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.87%. Comparing base (2acb3ef) to head (994c5b1).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/coreComponents/mesh/FaceElementSubRegion.cpp 0.00% 3 Missing ⚠️
...rc/coreComponents/mainInterface/ProblemManager.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3965      +/-   ##
===========================================
- Coverage    58.87%   58.87%   -0.01%     
===========================================
  Files         1353     1353              
  Lines       112953   112959       +6     
===========================================
  Hits         66504    66504              
- Misses       46449    46455       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant