fix: Fix bug in L2 norm calculation for isothermal#3954
Open
fix: Fix bug in L2 norm calculation for isothermal#3954
Conversation
dkachuma
added
ci: run CUDA builds
paveltomin
approved these changes
Jan 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3954 +/- ##
========================================
Coverage 58.87% 58.87%
========================================
Files 1353 1353
Lines 112953 112954 +1
========================================
+ Hits 66504 66505 +1
Misses 46449 46449 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tjb-ltk
reviewed
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Should defaults in well also be set ?
Contributor
Author
There was a problem hiding this comment.
Well looks to be handled differently. There's no volume balance and it seems it's all sized correctly (1 for isothermal and 2 for thermal). CompositionalMultiphaseWell.cpp:1379-1388
dkachuma
added
flag: ready for review
ci: run integrated tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For isothermal models, the normaliser for the L2 normal calculation was not being populated leading to a divide by zero down the line. This PR simply sets this to the minimum value to bypass the floating point exception.