Draft
Conversation
…phase properties reflecting the comments from the meeting on Aug-13-2024
… Bertrand Denel for pointing them out
…to the compute flux
…' into CapillaryInterfaceConditions
…, it compiles with no errors but may not converge
* enable creation of new FaceElementSubregion entries from interface sets * wip: draft for a working example * wip: parsing registered container "interfaceFaceSetNames" * wip: two-regions example * wip: initializePreSubGroups() is executing * wip: inelegant access to relperms * wip: filling up m_constitutitveFluidModels * wip: apply formatter uncrustify * Update ImmiscibleMultiphaseFlow.cpp * Update ImmiscibleMultiphaseFlow.cpp * Update ImmiscibleMultiphaseFlow.cpp * Update uni_directional_flow_interface_condition.xml * wip: commenting some attributions of addToFractureMesh * wip: split attributions of addToFractureMesh * wip: strongly typed implementation * Update immiscibleTwoPhase_GravitySegregation_1d.xml * wip: remove reference to nonexistent test file * wip: apply formatter uncrustify * added capPressure and fluid to m_constitutitveFluidModels * wip: rename attribute m_constitutitveFluidModels to m_interfaceConstitutivePairs * wip: extending example xml file * Update ImmiscibleMultiphaseFlow.cpp * Update ImmiscibleMultiphaseFlow.cpp * Update SurfaceElementRegion.cpp * refactor: split functionality of addToFractureMesh * Update ImmiscibleMultiphaseKernels.hpp * Update ImmiscibleMultiphaseKernels.hpp * passing m_interfaceFaceSetNames and m_interfaceConstitutivePairs to the FluxComputeKernel * some cleanup * wip: reducing signature of addToSurfaceMesh Co-Authored-By: Randolph Settgast <rrsettgast@gmail.com> * run formatter uncrusitfy Co-Authored-By: Randolph Settgast <rrsettgast@gmail.com> Revert "run formatter uncrusitfy" This reverts commit c801af3c526046770fff6460ee07025824e62a2b. run formatter uncrusitfy * wip: using originalFaceToEdgeMap * fix: unused variable 'edgeMap' * Update SurfaceElementRegion.cpp * Update SurfaceElementRegion.cpp * Update SurfaceElementRegion.cpp * Update SurfaceElementRegion.hpp * Update ImmiscibleMultiphaseFlow.cpp * wip: adding a index map between interfaceRegion and its associated "Connectors" * Update StencilBase.hpp * Update StencilBase.hpp * Update ImmiscibleMultiphaseFlow.cpp * wip: Simplify implementation * wip: uncrustify style * wip: remove geos scope * Update ImmiscibleMultiphaseKernels.hpp * Update ImmiscibleMultiphaseKernels.hpp * Update ImmiscibleMultiphaseFlow.cpp * debugged and working local solver for the interface conditions that converges for viscous, gravity, and capillary fluxes * Update StencilBase.hpp * Update ImmiscibleMultiphaseFlow.hpp Introducing an alternative container m_connectorIndicesByInterfaceRegion this implies call the nonlinear interface solver in a separate call * WIP: adding some extra comments * wip: fix indentation * Adding an example input file * refactor: clean up files * Update ImmiscibleMultiphaseKernels.hpp * Update ImmiscibleMultiphaseKernels.hpp * Moved the local solver to be an inline static function * change interfaceConstitutivePairs type from ConstitutiveBase to each model's type Base * added a unit Test for the local interface conditions solver and resolved some merge conflicts * adding unitTest --------- Co-authored-by: Omar Duran <omaryesiduran@gmail.com> Co-authored-by: Ammara-14 <ammara@stanford.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is for implementing the application of discrete capillary interface conditions at heterogeneous rock interfaces to enhance capillary-dominated flux computation accuracy without extreme grid refinement.