Skip to content

feat: feature/byer3/well constraints#3862

Open
tjb-ltk wants to merge 56 commits intodevelopfrom
feature/byer3/well_constraints
Open

feat: feature/byer3/well constraints#3862
tjb-ltk wants to merge 56 commits intodevelopfrom
feature/byer3/well_constraints

Conversation

@tjb-ltk
Copy link
Contributor

@tjb-ltk tjb-ltk commented Oct 13, 2025

feat: Formalize definition of well constraints to

  1. allow more than 2 constraints per well
  2. minimize restrictions on rate type
  3. allow production/injection constraints for one well (future capability)
  4. improve code for constraint processing in general and also needed for well estimator
  5. current implementation requires schema changes, script provided scripts/convert_well_schema.py

ToDo

  1. add validation based on current implementation rules
  2. add control switch logging
  3. organized constraint hpp and cpp so all methods are in similar order
  4. submit new input files

Subsequent PR's based on this PR

  1. New constraint activation/test models (Liquid, needs phase name validation, single phase mass rate, ...)
  2. change balance equation scaling, should be current rate?, not constraint rate, this will change results but will clean up residual check code
  3. well estimator
  4. well head pressure constraint

tjb-ltk and others added 6 commits October 14, 2025 06:47
…t compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml
…d convert compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml"

This reverts commit fa61ab1.
@tjb-ltk tjb-ltk added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Oct 24, 2025
@MelReyCG
Copy link
Contributor

@tjb-ltk Is it ready for review?

@tjb-ltk tjb-ltk added type: feature New feature or request ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires rebaseline Requires rebaseline branch in integratedTests changes XML input ci: run code coverage enables running of the code coverage CI jobs labels Jan 14, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 51.38889% with 560 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.64%. Comparing base (2acb3ef) to head (aec6453).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...physicsSolvers/fluidFlow/wells/SinglePhaseWell.cpp 52.40% 168 Missing ⚠️
...s/CompositionalMultiphaseWellConstraintKernels.hpp 18.71% 152 Missing ⚠️
...wells/kernels/SinglePhaseWellConstraintKernels.hpp 0.00% 45 Missing ⚠️
...ts/physicsSolvers/fluidFlow/wells/WellControls.cpp 69.15% 33 Missing ⚠️
...lls/kernels/CompositionalMultiphaseWellKernels.cpp 48.93% 24 Missing ⚠️
...lvers/fluidFlow/wells/WellLiquidRateConstraint.cpp 0.00% 21 Missing ⚠️
...Solvers/fluidFlow/wells/WellMassRateConstraint.cpp 0.00% 18 Missing ⚠️
...nels/ThermalCompositionalMultiphaseWellKernels.hpp 5.55% 17 Missing ⚠️
...lls/kernels/CompositionalMultiphaseWellKernels.hpp 0.00% 16 Missing ⚠️
...icsSolvers/fluidFlow/wells/WellConstraintsBase.cpp 63.33% 11 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3862      +/-   ##
===========================================
- Coverage    58.87%   58.64%   -0.23%     
===========================================
  Files         1353     1371      +18     
  Lines       112953   113762     +809     
===========================================
+ Hits         66504    66719     +215     
- Misses       46449    47043     +594     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes XML input ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants