feat: Augmented Lagrangian (slip and open modes) by matteofrigo5 · Pull Request #3217 · GEOS-DEV/GEOS

matteofrigo5 · 2024-07-10T15:59:42Z

This PR introduces the following features:

Augmented Lagrangian Method for Contact Mechanics: This implementation finalizes the preliminary work from PR Augmented Lagrangian (stick mode) - InterfaceKernelBase - Bubble Functions #3130, fully developing the method for both slip and open modes.
Adaptive Penalty Coefficient Strategy: A simple adaptive strategy for setting the penalty coefficient has been implemented.

codecov · 2024-07-12T22:46:18Z

Codecov Report

Attention: Patch coverage is 0% with 602 lines in your changes missing coverage. Please review.

Project coverage is 56.31%. Comparing base (3b5b5a6) to head (bb696c1).
Report is 85 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ntact/SolidMechanicsAugmentedLagrangianContact.cpp	0.00%	257 Missing ⚠️
...omponents/constitutive/contact/CoulombFriction.hpp	0.00%	103 Missing ⚠️
...s/contact/SolidMechanicsALMSimultaneousKernels.hpp	0.00%	103 Missing ⚠️
...niteElement/elementFormulations/LagrangeBasis1.hpp	0.00%	55 Missing ⚠️
...csSolvers/contact/SolidMechanicsALMKernelsBase.hpp	0.00%	31 Missing ⚠️
...ntact/SolidMechanicsAugmentedLagrangianContact.hpp	0.00%	17 Missing ⚠️
...hysicsSolvers/contact/SolidMechanicsALMKernels.hpp	0.00%	12 Missing ⚠️
...Solvers/contact/SolidMechanicsALMBubbleKernels.hpp	0.00%	9 Missing ⚠️
...reComponents/constitutive/contact/FrictionBase.hpp	0.00%	6 Missing ⚠️
...reComponents/constitutive/ConstitutivePassThru.hpp	0.00%	2 Missing ⚠️
... and 5 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3217      +/-   ##
===========================================
- Coverage    56.59%   56.31%   -0.29%     
===========================================
  Files         1064     1065       +1     
  Lines        89766    90227     +461     
===========================================
  Hits         50807    50807              
- Misses       38959    39420     +461

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/coreComponents/finiteElement/elementFormulations/LagrangeBasis1.hpp

src/coreComponents/physicsSolvers/contact/ContactFields.hpp

src/coreComponents/physicsSolvers/contact/SolidMechanicsAugmentedLagrangianContact.cpp

…mbda functions

…ning up the code

src/coreComponents/constitutive/ConstitutivePassThru.hpp

…nels.hpp

host-configs/Stanford/sherlock-gcc10-ompi4.1.2-openblas0.3.10.cmake

src/coreComponents/physicsSolvers/contact/SolidMechanicsAugmentedLagrangianContact.hpp

rrsettgast · 2024-09-13T21:04:41Z

src/coreComponents/constitutive/contact/FrictionlessContact.hpp

   * @return the wrapper
   */
-  KernelWrapper createKernelWrapper() const;
+  KernelWrapper createKernelUpdates() const;


Update was from the initial implementation of the concept which was originally used to wrap the material update.

src/coreComponents/physicsSolvers/contact/ContactFields.hpp

src/coreComponents/constitutive/contact/CoulombFriction.hpp

src/coreComponents/physicsSolvers/contact/SolidMechanicsALMKernelsBase.hpp

src/coreComponents/constitutive/contact/CoulombFriction.hpp

rrsettgast · 2024-09-14T00:27:18Z

@matteofrigo5 documentation errors:

/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/intersectFrac/Example.rst:72: WARNING: start-after pattern not found: <!-- SPHINX_MESH -->
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/intersectFrac/Example.rst:81: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/ContactMechanics_TFrac_base.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/intersectFrac/Example.rst:112: WARNING: end-before pattern not found: <!-- SPHINX_SOLVER_END -->
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/intersectFrac/Example.rst:127: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/ContactMechanics_TFrac_base.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/intersectFrac/Example.rst:148: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/ContactMechanics_TFrac_base.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/intersectFrac/Example.rst:174: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/ContactMechanics_TFrac_base.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/intersectFrac/Example.rst:233: WARNING: Exception occurred in plotting intersectFracFigure
 from /home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/intersectFrac/intersectFracFigure.py:
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/envs/3217/lib/python3.10/site-packages/matplotlib/sphinxext/plot_directive.py", line 552, in _run_code
    exec(code, ns)
  File "<string>", line 219, in <module>
  File "<string>", line 155, in main
  File "<string>", line 30, in getMechanicalParametersFromXML
  File "/home/docs/.asdf/installs/python/3.10.14/lib/python3.10/xml/etree/ElementTree.py", line 1222, in parse
    tree.parse(source, parser)
  File "/home/docs/.asdf/installs/python/3.10.14/lib/python3.10/xml/etree/ElementTree.py", line 569, in parse
    source = open(source, "rb")
FileNotFoundError: [Errno 2] No such file or directory: '../../../../../../../inputFiles/lagrangianContactMechanics/ContactMechanics_TFrac_base.xml'
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/singleFracCompression/Example.rst:82: WARNING: start-after pattern not found: <!-- SPHINX_MESH -->
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/singleFracCompression/Example.rst:113: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/ContactMechanics_SingleFracCompression_base.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/singleFracCompression/Example.rst:127: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/ContactMechanics_SingleFracCompression_base.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/singleFracCompression/Example.rst:148: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/ContactMechanics_SingleFracCompression_base.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/singleFracCompression/Example.rst:173: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/ContactMechanics_SingleFracCompression_base.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/singleFracCompression/Example.rst:232: WARNING: Exception occurred in plotting singleFracCompressionFigure
 from /home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/singleFracCompression/singleFracCompressionFigure.py:
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/envs/3217/lib/python3.10/site-packages/matplotlib/sphinxext/plot_directive.py", line 552, in _run_code
    exec(code, ns)
  File "<string>", line 187, in <module>
  File "<string>", line 138, in main
  File "<string>", line 38, in getMechanicalParametersFromXML
  File "/home/docs/.asdf/installs/python/3.10.14/lib/python3.10/xml/etree/ElementTree.py", line 1222, in parse
    tree.parse(source, parser)
  File "/home/docs/.asdf/installs/python/3.10.14/lib/python3.10/xml/etree/ElementTree.py", line 569, in parse
    source = open(source, "rb")
FileNotFoundError: [Errno 2] No such file or directory: '../../../../../../../inputFiles/lagrangianContactMechanics/ContactMechanics_SingleFracCompression_base.xml'
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/sneddon/Example.rst:102: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/Sneddon_contactMechanics_benchmark.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/sneddon/Example.rst:158: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/Sneddon_contactMechanics_benchmark.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/sneddon/Example.rst:212: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/Sneddon_contactMechanics_base.xml' not found or reading it failed
/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/src/docs/sphinx/advancedExamples/validationStudies/faultMechanics/sneddon/Example.rst:245: WARNING: Include file '/home/docs/checkouts/readthedocs.org/user_builds/geosx-geosx/checkouts/3217/inputFiles/lagrangianContactMechanics/Sneddon_contactMechanics_base.xml' not found or reading it failed```

…to feature/mfrigo/ALM_slip

* Implementation of slip and open modes for ALM * Adding a new inputFile for ALM and bug (bubble functions) fixed * Bug bubble functions gradient fixed * Adding initial stress contribution for bubble functions - updating lambda functions * Adding nested ALM * Adding simultaneous and nested ALM * Moving the traction update into the friction model * Moved contact constitutive behavior from ALM to the friction law

Start of the implementation of slip and open modes for ALM

14095fc

matteofrigo5 requested review from CusiniM and rrsettgast as code owners July 10, 2024 15:59

matteofrigo5 self-assigned this Jul 10, 2024

matteofrigo5 added type: feature New feature or request flag: requires rebaseline Requires rebaseline branch in integratedTests labels Jul 10, 2024

matteofrigo5 requested a review from castelletto1 July 10, 2024 16:10

CusiniM changed the title ~~Augmented Lagrangian (slip and open modes)~~ feat: Augmented Lagrangian (slip and open modes) Jul 12, 2024

matteofrigo5 added 2 commits July 16, 2024 10:55

Debuging slip mode

37ff3d0

Adding a new inputFile for ALM and bug (bubble functions) fixed

bff5602

matteofrigo5 requested review from cssherman and jhuang2601 as code owners July 18, 2024 01:33

Bug bubble functions gradient fixed

beff149

matteofrigo5 requested a review from andrea-borio as a code owner August 5, 2024 02:59

Updating automatic penalty setting

5f5bfa3

CusiniM reviewed Aug 8, 2024

View reviewed changes

src/coreComponents/finiteElement/elementFormulations/LagrangeBasis1.hpp Show resolved Hide resolved

CusiniM reviewed Aug 8, 2024

View reviewed changes

src/coreComponents/physicsSolvers/contact/ContactFields.hpp Outdated Show resolved Hide resolved

CusiniM reviewed Aug 8, 2024

View reviewed changes

matteofrigo5 added 5 commits August 7, 2024 19:48

Fixed the MPI bug and started cleaning up the code

8fc501f

Adding initial stress contribution for bubble functions - updating la…

dee0997

…mbda functions

Fixing update lists of stick-slip-open elements

216c0d0

Adding nested ALM

0a4121a

Adding simultaneous and nested ALM - bug in the jacobian fixed - clea…

e2b3a71

…ning up the code

matteofrigo5 requested review from dkachuma, joshua-white and paveltomin as code owners August 22, 2024 00:31

paveltomin requested review from Guotong-Ren and sohailwaziri August 22, 2024 14:13

paveltomin reviewed Aug 22, 2024

View reviewed changes

src/coreComponents/constitutive/ConstitutivePassThru.hpp Outdated Show resolved Hide resolved

matteofrigo5 and others added 7 commits September 6, 2024 17:27

Fixed reviewer's comments (3)

5ad715f

Fixed vtk-silo in the inputFiles/lagrangeContactMechanics

778e410

Fixed vtk-silo in the inputFiles/lagrangeContactMechanics

647efc0

Merge branch 'develop' into feature/mfrigo/ALM_slip

38183f0

Update src/coreComponents/physicsSolvers/contact/SolidMechanicsALMKer…

0d0d1d1

…nels.hpp

Merge branch 'develop' into feature/mfrigo/ALM_slip

7fa109e

fix bug

b63b9ed

rrsettgast approved these changes Sep 13, 2024

View reviewed changes

CusiniM reviewed Sep 13, 2024

View reviewed changes

src/coreComponents/constitutive/contact/CoulombFriction.hpp Outdated Show resolved Hide resolved

Update src/coreComponents/constitutive/contact/CoulombFriction.hpp

cdbcd8c

rrsettgast reviewed Sep 13, 2024

View reviewed changes

src/coreComponents/constitutive/contact/CoulombFriction.hpp Outdated Show resolved Hide resolved

CusiniM reviewed Sep 13, 2024

View reviewed changes

src/coreComponents/physicsSolvers/contact/SolidMechanicsALMKernelsBase.hpp Outdated Show resolved Hide resolved

CusiniM reviewed Sep 13, 2024

View reviewed changes

src/coreComponents/constitutive/contact/CoulombFriction.hpp Outdated Show resolved Hide resolved

Apply suggestions from code review

af1dcd3

matteofrigo5 and others added 7 commits September 15, 2024 04:28

Fixing documentation error

065a962

Adding doxygen comments

add8a0a

Merge branch 'develop' into feature/mfrigo/ALM_slip

c2d3ab1

fix documentation error:

0202b50

Merge branch 'feature/mfrigo/ALM_slip' of github.com:GEOS-DEV/GEOS in…

6867637

…to feature/mfrigo/ALM_slip

Change penalty to iterativePenalty

78e74de

update baselines.

c7c6bff

CusiniM requested a review from wrtobin as a code owner September 16, 2024 19:09

matteofrigo5 added 2 commits September 17, 2024 02:48

Fixed bug parallel execution

9b4a604

Update baselines

bb696c1

CusiniM merged commit 7130462 into develop Sep 17, 2024

CusiniM deleted the feature/mfrigo/ALM_slip branch September 17, 2024 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Augmented Lagrangian (slip and open modes) #3217

feat: Augmented Lagrangian (slip and open modes) #3217
CusiniM merged 48 commits intodevelopfrom
feature/mfrigo/ALM_slip

matteofrigo5 commented Jul 10, 2024

Uh oh!

codecov bot commented Jul 12, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrsettgast Sep 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrsettgast commented Sep 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

matteofrigo5 commented Jul 10, 2024

Uh oh!

codecov bot commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrsettgast Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrsettgast commented Sep 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jul 12, 2024 •

edited

Loading