Fix empty response body when debug log is enabled#74
Open
houbi56 wants to merge 1 commit intoFubarDevelopment:release/2.0from
Open
Fix empty response body when debug log is enabled#74houbi56 wants to merge 1 commit intoFubarDevelopment:release/2.0from
houbi56 wants to merge 1 commit intoFubarDevelopment:release/2.0from
Conversation
fubar-coder
requested changes
Nov 24, 2022
Collaborator
fubar-coder
left a comment
fubar-coder
left a comment
There was a problem hiding this comment.
This looks very good - except one thing I didn't previously think of: The response must not be logged when the response stream isn't seekable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change to fix stream already consumed by the LoggingWebDavResponse. Resolves #73
IWebDavResult now writes the result to the http output except for the body which is buffered in a memory stream.
The memory stream is then copied to the httpresult body.
This avoids the executing the result processing twice.