Load PHP files in DI, remove XML config#654
Conversation
|
thanks a lot! not sure about the security advisory errors. i think we should simply disable the composer audit function - it is up to the applications to respect or ignore them. and symfony 6.4 is still supported, so i hope a fixed version releases soon. the console application add is a different issue, would need to check what the new way of adding commends is. we can do that in a separate MR. |
Ah, ok, I see it now, Config component depends on DI.
As for this, sure I can disable security advisories. However, I tried installing Symfony 6.4 locally with PHP 8.2 and it works fine, no advisory errors given, so I'm not really sure why it fails here. |
94e3eb8 to
ff65f40
Compare
It turns out it's just |
This switches DI to actually load PHP files instead of XML and removes the old XML config.
Note: I did not test this on Symfony 6.4, only 7.4 and 8.0, but 6.4 does have
PhpFileLoader, so presumably it should work fine.