Add support for configurable HTTP request factory for proxy clients#646
Conversation
a8c4e27 to
d1601f2
Compare
There was a problem hiding this comment.
yeah, seems a reasonable idea to have this.
can you please add this to the documentation as well so the option is explained? and a note in the changelog would be nice.
and if you have time to add a test that ensures the factory is actually configured when specified in the config, that would be nice too.
Will do that.
Please note that this PR targets
I'll look into it. |
|
oh, i did not realize this goes to 2.x alright, i can do a new minor of 2.x for this to help you out. i will wait until you added the doc, changelog and if you manage to add a test. |
Co-authored-by: David Buchmann <david@liip.ch>
|
there you go https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/2.18.0 thanks for the contributions! |
|
Wow, that was fast! Thank you very much 💚 |
It would be great if you could configure the third parameter of the
\FOS\HttpCache\ProxyClient\HttpProxyClientwithout having to overwrite the entire service.