Allowing no file in the PathProcessor#614
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #614 +/- ##
============================================
+ Coverage 95.86% 95.90% +0.04%
- Complexity 110 111 +1
============================================
Files 11 11
Lines 290 293 +3
============================================
+ Hits 278 281 +3
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
About the trailing comma errors, I'm open to fixing them if needed. |
|
Same issue here. Occurs when removing a record where the field that would store the file name is null. |
|
Calling |
|
I made the change to no longer call the getPathProcessor() method as you suggested. I believe this is indeed more appropriate |
|
@ADmad anything else we can contribute to get this PR approved? |
In cases where the database record has the file field set to null, deleting the record will result in a type error in the $data field, as null is not an acceptable value at that moment.