Changing default directory_visibility#611
Merged
ADmad merged 1 commit intoFriendsOfCake:masterfrom Mar 2, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
============================================
+ Coverage 95.84% 95.87% +0.02%
- Complexity 109 110 +1
============================================
Files 11 11
Lines 289 291 +2
============================================
+ Hits 277 279 +2
Misses 12 12 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an environment where we have a web server running with the
nobodyuser and PHP running in its own user, it is not possible by default for http server to directly access files in folders created by this plugin. I believe that if the file has public visibility by default, it makes sense to me that the folder should also be.