Add SVG diagrams to Triangle documentation#19
Merged
Conversation
- Added diagram 1: Triangle types by side length (equilateral, isosceles, scalene) - All triangles have base at bottom - Equilateral has perpendicular tick marks on all three sides - Isosceles has double tick marks on two equal sides - Scalene has labeled sides a, b, c - Added diagram 2: Triangle types by angle measure (acute, right, obtuse) - Acute triangle shows three 60° angles with concave arcs - Right triangle shows 90° angle with square symbol, two 45° angles - Obtuse triangle shows 120° obtuse angle and two acute angles (40°, 20°) - All angle arcs are properly concave and touch triangle sides - All labels are carefully positioned for clarity
- Added diagram 4: Three triangles showing different cevian types - Median: Blue dashed line from vertex to midpoint with equal segment marks - Altitude: Red dashed line perpendicular to base with right angle symbol - Angle bisector: Purple dashed line with equal angle arcs at vertex - All cevians properly positioned with clear visual markers - Updated TODO to remove completed diagram 4
- Circumcenter: perpendicular bisectors of sides meeting at center, circumcircle passing through all vertices, tick marks showing bisected sides, right angle symbols positioned inside triangle - Incenter: angle bisectors meeting at center, incircle tangent to all sides and fitting inside triangle - Centroid: medians from vertices to opposite midpoints converging at center, tick marks showing bisected sides - Orthocenter: altitudes from vertices perpendicular to opposite sides intersecting at orthocenter All four centers displayed in single 800x280 SVG with proper geometric positioning and visual markers. Updated TODO list to reflect completion.
- Right triangle with three squares showing a² + b² = c² - Blue square on vertical leg (a²) - Green square on horizontal leg (b²) - Red square on hypotenuse (c²), rotated 45° to align with hypotenuse - Formula displayed at top of diagram - Right angle indicator at 90° corner - Centered diagram with proper alignment of all squares - SVG wrapped in centered div for better presentation
- Two triangles side-by-side showing the special right triangle ratios - 45-45-90 triangle: Shows 1:1:√2 ratio with equal legs - 30-60-90 triangle: Shows 1:√3:2 ratio - Clear side labels (a, a√3, 2a) for both triangles - Right angle indicators for both triangles - Centered diagram with titles and ratio information - Angle arc indicators commented out (too difficult to position accurately) Completes all 7 planned diagrams for the Triangles documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 7 comprehensive SVG diagrams to the Triangle documentation to visually illustrate key geometric concepts. All diagrams are embedded as
@raw htmlblocks and centered for better presentation.Diagrams Added
Technical Details
<div style="text-align: center;">wrappersTesting
julia --project=. docs/make.jlRelated
Follows the same pattern established in the Quadrilateral documentation (using
@raw htmlSVG blocks).