Added a clear and a display random stat functionality#7
Open
weagle08 wants to merge 4 commits intoForestOfLight:mainfrom
Open
Added a clear and a display random stat functionality#7weagle08 wants to merge 4 commits intoForestOfLight:mainfrom
weagle08 wants to merge 4 commits intoForestOfLight:mainfrom
Conversation
ForestOfLight
requested changes
Jun 1, 2025
Owner
ForestOfLight
left a comment
There was a problem hiding this comment.
Thanks for contributing! A few things before I can approve this:
- Please remove the CMD_CLEAR & CMD_RANDOM variables. They reduce code duplication, but I've been planning to make them all into an enum once proper custom commands are good enough. For now, adhere to the current setup.
- Not sure the clear command is a good idea. Did you have a specific time it would be useful instead of "reset all"?
Author
|
So my server needed a way to fully clear the accumulated stats in the stat list for use when playing simple stat poker. Without fully clearing you get a lot of stats that have not been incremented at all. |
Owner
|
Ah- this is on my backlog for StatisticDisplay. Really what you need is a better way to look through the available statistics. The current listing command is basically unusable because of the volume of characters. |
Owner
|
Stats are now much more easily searchable as of 1.1.7. Does this solve the need for a clear command for you? Happy to merge the random command as long as the bulk of the logic is in its own method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clear command requires a server restart. That was the best approach in my oppinion for a command that should be used pretty in-frequently. It requires this because of how the events self register on import. Leave me suggestions if this is not ideal.