Revert "fix: add required repository argument for rulesets"#65
Revert "fix: add required repository argument for rulesets"#65vedantthapa merged 1 commit intomainfrom
repository argument for rulesets"#65Conversation
This reverts commit 71cc7c9.
Summary of ChangesHello @vedantthapa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undoes a previous modification that introduced a mandatory Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that added a required repository argument for rulesets. While the revert is applied consistently across all files, it appears to re-introduce a critical issue. The repository argument is necessary for creating github_repository_ruleset resources when the Terraform GitHub provider is configured at the organization level. By removing this argument from the ruleset module, creating repository-level rulesets will likely fail in such configurations. I have added a critical comment in modules/ruleset/variables.tf explaining why this revert is problematic and recommending that the original changes from PR #64 be restored.
Reverts #64