Conversation
Contributor
jrschumacher
commented
Jan 4, 2025
jrschumacher
commented
- updated to support multiplatform builds
- update to the latest stable version of Go
- disable glibc, DWARF debugging, and symbol table
- use docker scratch file
- use non-root user (1000 can often be a sudoer on a host machine)
- add healthcheck
- add OCI labels
- updated to support multiplatform builds - update to the latest stable version of Go - disable glibc, DWARF debugging, and symbol table - use docker scratch file - use non-root user (1000 can often be a sudoer on a host machine) - add healthcheck - add OCI labels
Fesaa
requested changes
Jan 4, 2025
Dockerfile
Outdated
| # Healthcheck | ||
| HEALTHCHECK --interval=30s --timeout=30s --start-period=5s --retries=3 CMD [ "curl", "-f", "http://localhost:8080/health" ] || exit 1 | ||
|
|
||
| LABEL maintainer="https://github.cowm/Fesaa/iCalMerger" |
Owner
|
Heya, I'm not sure what the goal of this pull request is? Is there something you are missing in the current docker image? |
Contributor
Author
|
@Fesaa resolved this issues. BTW if you use the squash and merge it will make the git-history nice and clean and won't "steal" credit from outside contribution. Your call though.
|
jrschumacher
commented
Jan 5, 2025
Owner
|
Looks good, I will merge tomorrow. I'd rather not squash. Out of principle, in case there is a single commit, I'd want to revert. Have had some small annoying issues this way 😅 |
Fesaa
approved these changes
Jan 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.