Open
Conversation
Added documentation for Algo_QC class. This includes Quasi Compressible hypothesis equations, LES formulations, and LES models and bibliography.
In files OpDiffTurbIJK.tpp and OpDiffTurbIJKScalar.tpp in the compute_flux_ method, the way functional viscosity models were initialized made it so there was an illegal memory dereferencing when constructing a ConstIJK_double_ptr pointer because of a memory access of a non initialized pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving a bug in the computing of the flux where there was an illegal pointer dereferencing during the initialization of a
ConstIJK_double_ptrvariable. This commit aims at correcting these mistakes.