-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[TEST - do not merge] Create test-include.md #80697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| keywords: Okta Workflows, Expensify API, user provisioning, deprovisioning, Advanced Employee Updater, automate onboarding, SSO, identity management | ||
| --- | ||
|
|
||
| {% include docs/articles/Unlisted/Automate-User-Provisioning-in-Expensify-with-Okta-Workflows.md %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Readiness violation: This file only contains a Jekyll include statement and no actual content. This creates problems for AI comprehension because:
- The content is not directly accessible - AI systems reading this file won't see the actual article content
- Search indexing may not work properly
- The file lacks the structural elements required for proper documentation (breadcrumbs, headings, body content)
Recommendation: Either:
- Inline the full content from the included file directly into this document, OR
- If this is meant to be a redirect/alias, consider using a different approach that maintains content visibility
| keywords: Okta Workflows, Expensify API, user provisioning, deprovisioning, Advanced Employee Updater, automate onboarding, SSO, identity management | ||
| --- | ||
|
|
||
| {% include docs/articles/Unlisted/Automate-User-Provisioning-in-Expensify-with-Okta-Workflows.md %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readability violation: The file lacks essential structural elements:
- Missing breadcrumb path - There should be a navigation breadcrumb below the H1 heading (e.g., "Settings > Workspaces > Integrations > Okta")
- No H1 heading - The title in YAML frontmatter is not the same as having an actual
# Headingin the content - No body content - The file only has a Jekyll include statement with no visible content
This makes the document impossible to scan or read in its current form.
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| title: Automate User Provisioning in Expensify with Okta Workflows | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terminology violation: The title uses "User" which should be changed to "Member" to match Expensify style standards.
Suggested fix:
title: Automate Member Provisioning in Expensify with Okta Workflows| @@ -0,0 +1,7 @@ | |||
| --- | |||
| title: Automate User Provisioning in Expensify with Okta Workflows | |||
| description: Set up Okta Workflows with Expensify’s API to automatically provision, update, and deprovision users. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terminology violation: The description uses "users" which should be "members" to match Expensify style standards.
Suggested fix:
description: Set up Okta Workflows with Expensify's API to automatically provision, update, and deprovision members.| --- | ||
| title: Automate User Provisioning in Expensify with Okta Workflows | ||
| description: Set up Okta Workflows with Expensify’s API to automatically provision, update, and deprovision users. | ||
| keywords: Okta Workflows, Expensify API, user provisioning, deprovisioning, Advanced Employee Updater, automate onboarding, SSO, identity management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terminology violation: The keywords include "user provisioning" which should be "member provisioning" to match Expensify style standards.
Suggested fix:
keywords: Okta Workflows, Expensify API, member provisioning, deprovisioning, Advanced Employee Updater, automate onboarding, SSO, identity management
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a test file ( Scores Summary
Key FindingsCritical Issues:
Positive Aspects:
Design Pattern Issues:
RecommendationsPriority Actions Required:
Files Reviewed
Technical ContextThe Expensify Help site uses Jekyll with a specific architecture:
Recommendation: Do not merge this PR. The pattern used will not work in the current documentation system. If there's a specific use case driving this test, please clarify the goal so the team can recommend an appropriate solution that works within the existing architecture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8057317a08
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| keywords: Okta Workflows, Expensify API, user provisioning, deprovisioning, Advanced Employee Updater, automate onboarding, SSO, identity management | ||
| --- | ||
|
|
||
| {% include docs/articles/Unlisted/Automate-User-Provisioning-in-Expensify-with-Okta-Workflows.md %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Jekyll include from _includes or include_relative
The new article uses {% include docs/articles/Unlisted/… %}, but Jekyll’s include tag only resolves files inside docs/_includes (see docs/README.md section describing includes). Since the target Markdown file lives under docs/articles/Unlisted, the build will error with “included file not found in _includes” and this page won’t render when the docs site is generated. Consider moving the included file into _includes or switching to {% include_relative Automate-User-Provisioning-in-Expensify-with-Okta-Workflows.md %} so the include resolves correctly.
Useful? React with 👍 / 👎.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari