-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Update Travel help docs for multiple changes #80692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://0d337e50.helpdot.pages.dev ⚡️ Updated articles: |
Adding more updates to Hotel configuration. per https://docs.google.com/spreadsheets/d/1dK3yLYzw7Xa6SXyF4DNj4QJOiNS-ty9xDb3uqsexfuE/edit?usp=sharing
Updated access instructions
Updating access instructions.
Updating access instructions.
strepanier03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figured I'd update the access instructions after our chat in Slack here - https://expensify.slack.com/archives/C02QSAC6BJ8/p1769024505847459
|
I'll review the builds again with the updated access instructions but my last review of my more important changes was good. |
Noticed some odd formatting issues, trying to correct.
Figured out the formatting issue, fixed it with this change.
|
One last change, figured out the Hotel settings doc formatting issues. Will review fresh build before setting for review. |
HelpDot Documentation ReviewOverall AssessmentThis PR updates three Travel help documentation files with significant improvements to structure, new feature documentation, and standardized access instructions. The changes add valuable content about report scheduling, property type restrictions, and enhanced flight/hotel policy settings. Overall quality is strong, though there are some inconsistencies in formatting and style that should be addressed. Scores Summary
Key FindingsPositive Aspects:
Issues Identified:
RecommendationsPriority Actions:
Suggestions for Improvement:
Files Reviewed
Note: The core content quality is high and these updates will significantly improve the Travel documentation. The recommended changes are primarily formatting and style refinements. |
docs/articles/travel/travel-policy/Configuring-Hotel-Settings.md
Outdated
Show resolved
Hide resolved
docs/articles/travel/travel-policy/Configuring-Hotel-Settings.md
Outdated
Show resolved
Hide resolved
docs/articles/travel/travel-policy/Configuring-Hotel-Settings.md
Outdated
Show resolved
Hide resolved
docs/articles/travel/travel-policy/Configuring-Hotel-Settings.md
Outdated
Show resolved
Hide resolved
Updated per suggestions.
Updating some suggested changes.
Made suggested updates.
Spelling error.
strepanier03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actioned all the suggestions by the GH bot that I agreed with and that made sense. Ready for you @stephanieelliott
COMING FROM: https://github.com/Expensify/Expensify/issues/593624
Updating travel docs - per https://docs.google.com/spreadsheets/d/1dK3yLYzw7Xa6SXyF4DNj4QJOiNS-ty9xDb3uqsexfuE/edit?usp=sharing
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari