-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Replace OnyxUpdate default union type with specific types - fifth batch #79685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
OlGierd03
wants to merge
35
commits into
Expensify:main
Choose a base branch
from
software-mansion-labs:@OlGierd03/replace_default_union_OnyxUpdate_type_fifth_batch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[No QA] Replace OnyxUpdate default union type with specific types - fifth batch #79685
OlGierd03
wants to merge
35
commits into
Expensify:main
from
software-mansion-labs:@OlGierd03/replace_default_union_OnyxUpdate_type_fifth_batch
+602
−407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype_annotations_uncovered_cases' into @OlGierd03/replace_default_union_OnyxUpdate_type_fifth_batch
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…ype_annotations_uncovered_cases' into @OlGierd03/replace_default_union_OnyxUpdate_type_fifth_batch
… - TrackedExpenseParams type
… - ConvertTrackedExpenseToRequestParams type
… - addTrackedExpenseToPolicy argument type
… - onyxData variable
… - removeTransactionFromDuplicateTransactionViolation argument
… - API/index.ts functions
blazejkustra
suggested changes
Jan 28, 2026
| quickAction, | ||
| }) ?? {}; | ||
| onyxData: trackExpenseInformationOnyxData, | ||
| } = getTrackExpenseInformation({ |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out this diff, looks suspicious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The changes in this PR are only at the type level, hence [No QA] tag
Fixed Issues
$ #73830
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A