feat: add iso-2022-jp fatal encoder #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
force-pushed
the
chalker/encoder/iso-2022-jp
branch
4 times, most recently
from
1cc7717 to
2e19abb
Compare
ChALkeR
force-pushed
the
chalker/encoder/iso-2022-jp
branch
from
2e19abb to
d11aa2f
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements the iso-2022-jp fatal encoder, completing support for all encoding formats in the Web Platform Tests. The encoder uses a state machine to manage transitions between ASCII, Roman, and JIS0208 character sets via escape sequences.
Changes:
- Added iso-2022-jp encoder implementation with state machine logic for character set transitions
- Removed iso-2022-jp exclusions from WPT test loader
- Added preencoder formula for iso-2022-jp pointer-to-bytes conversion
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/wpt/loader.cjs | Removed iso-2022-jp special case exclusions from encoder tests, enabling validation of the new encoder implementation |
| fallback/multi-byte.js | Added complete iso-2022-jp encoder with state machine (ASCII/Roman/jis0208 states), escape sequence management, halfwidth katakana mapping, and special character handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChALkeR
force-pushed
the
chalker/encoder/iso-2022-jp
branch
2 times, most recently
from
0a6149e to
cde11eb
Compare
ChALkeR
force-pushed
the
chalker/encoder/iso-2022-jp
branch
from
cde11eb to
52571f9
Compare
ChALkeR
force-pushed
the
chalker/encoder/iso-2022-jp
branch
from
52571f9 to
c3e38cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes on all test data in WPT
But that tests only single-codepoint encode, we need to test more, as iso-2022-jp maintains state
Also need to test failures