Open
Conversation
Author
|
Hey @roma-glushko I have created the PR. This is just a basic example of the logger, can you please explain and elaborate what else we need to add here. Probably you can help me with where to add these loogers in the CLI. |
Member
|
@hanshal101 Hey Hanshal, zap logger is already configured in the system: The goal of #274 is to simplify its usage further across the system by registering a configured instance globally and using it from there everywhere else. |
Author
|
Ohh cool, sorry I mis-understood this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES #274
FIXES #274
Description
In this PR I have added a
zaplogger for the CLIAdditional Information
{"level":"fatal","timestamp":"2024-06-27T16:42:37.861+0530","caller":"glide/main.go:44","msg":"💥Glide has finished with error","error":"required flag(s) \"config\" not set","stacktrace":"main.main\n\tH:/glide/main.go:44\nruntime.main\n\tC:/Users/hansh/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.4.windows-amd64/src/runtime/proc.go:271"}