Paul/v3 rates and fixes by paullinator · Pull Request #205 · EdgeApp/edge-reports-server

paullinator · 2025-11-20T20:52:29Z

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

Dependencies

none

Description

none

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1212068898421717

Note

Introduces chain/token metadata and rate-calculation upgrades, plus minor stability/config changes.

Types/partners: Extend StandardTx with deposit/payoutChainPluginId, deposit/payoutEvmChainId, and deposit/payoutTokenId. Update most partners to include these fields; lifi now fully populates them and sets payoutTxid and usdValue correctly.
Rates: Add V3 rates flow in ratesEngine using pluginId/tokenId via https://rates3.edge.app/v3/rates; fallback path uses the v2 rates API with improved fiat handling and same-currency short-circuit.
DB/setup: Add Mango index for orderId; initDbs now requires couchUris and always uses pooled Couch; default couchUris provided in config.
Payments: moonpay adds revolut payment type and consolidates mapping; banxa adds ACH mapping.
Tooling/UI: Rename npm scripts to start.*; destroyPartition exits with codes on success/failure; demo tightens API key check.

See CHANGELOG.md for details.

^{Written by Cursor Bugbot for commit 579527a. This will update automatically on new commits. Configure here.}

samholmes · 2026-01-07T00:24:00Z

package.json

+    "start.cache": "node -r sucrase/register src/indexCache.ts",
+    "start.rates": "node -r sucrase/register src/indexRates.ts",
+    "start.api": "node -r sucrase/register src/indexApi.ts",
+    "start.destroyPartition": "node -r sucrase/register src/bin/destroyPartition.ts",


Optional

I'd argue to keep the colon over the dot as a separator just because colon has become the de facto standard. Not worth being different from the rest of codebases here.

But they are such a pain to type.

samholmes · 2026-01-07T00:24:19Z

src/bin/destroyPartition.ts

    datelog(e)
+    process.exit(1)
  }
+  process.exit(0)


The reason why this was hanging is because of we don't cleanup the setTimeout in promiseTimeout util. This should be fixed as a separate commit.

samholmes · 2026-01-07T00:25:03Z

src/partners/lifi.ts

+  try {
+    tx = asTransfer(rawTx)
+  } catch (e) {
+    datelog(e)


createScopedLog already logs the date ISO string. So this try-catch is unnecessary.

samholmes · 2026-01-07T00:37:15Z

src/partners/lifi.ts

+    }
+    return standardTx
+  } catch (e) {
+    datelog(e)


Why are we catching just to log and rethrow when createScopedLog is already doing this?

samholmes · 2026-01-07T00:45:01Z

src/util/asEdgeTokenId.ts

+    default: {
+      // No token support:
+      // these chains don't support tokens
+      throw new Error('Tokens are not supported for this chain')


Plugin ID Token Support Details

eos Has customTokenTemplate - supports custom tokens via contract address

telos Has customTokenTemplate - supports custom tokens via contract address

wax Has customTokenTemplate - supports custom tokens via contract address

filecoin Has customTokenTemplate - supports custom tokens via contract address

zano Has builtinTokens (TALLY, BTCx) and customTokenTemplate for Asset IDs

These are tokens that Edge may have token support for that will cause this error to through if a transaction is detected with a token. Is that possible? Does the exchange plugins not support token swaps for these chains?

Yes. Exchange plugins do not support token swaps for the above chains. We want these to error so that we notice a plugin stops synchronizing, and then we could explicitly add support.

samholmes · 2026-01-07T00:48:40Z

src/ratesEngine.ts

+    transaction.depositChainPluginId != null &&
+    transaction.depositTokenId !== undefined &&
+    transaction.payoutChainPluginId != null &&
+    transaction.payoutTokenId !== undefined
+  ) {
+    return await updateTxValuesV3(transaction)
+  }
+
+  if (
+    transaction.depositChainPluginId != null &&
+    transaction.depositTokenId !== undefined &&
+    isFiatCurrency(transaction.payoutCurrency)
+  ) {
+    return await updateTxValuesV3(transaction)
+  }
+
+  if (
+    isFiatCurrency(transaction.depositCurrency) &&
+    transaction.payoutChainPluginId != null &&
+    transaction.payoutTokenId !== undefined
+  ) {
+    return await updateTxValuesV3(transaction)
+  }


Why not one if condition that is a disjunction of the three if conditions?

samholmes · 2026-01-07T00:58:39Z

src/initDbs.ts

-          await setupDatabase(config.couchDbFullpath, setup, options)
-      )
-    )
+  if (config.couchUris == null) {


If we're going to require couchUris, then make sure there is some default structure in the config? Otherwise, the commit prehook fails because the tests fail.

samholmes · 2026-01-07T01:04:38Z

src/types.ts

 })

+// v3/rates response cleaner (matches GUI's shape)
+const asV3CryptoAsset = asObject({


Would like these cleaners to be called asRatesV3*.

Add revolut

Have all plugins just set to undefined for now

cursor · 2026-01-26T18:33:17Z

src/partners/moonpay.ts

+  if (paymentMethod == null) {
+    throw new Error(`Unknown payment method: ${tx.paymentMethod} for ${tx.id}`)
  }
+  return paymentMethod


Moonpay mobile_wallet case now throws instead of returning null

High Severity

The refactored getFiatPaymentType function has a behavioral regression for the mobile_wallet payment method. When cardType is not 'apple_pay' or 'google_pay' (e.g., it's 'card' or missing), paymentMethod is set to null. The check on line 309 then throws an error for this case. The original implementation would return null without throwing, allowing these transactions to process with a null payment type.

we want it to throw so the plugin fails, and we properly edit the code to add the new types.

src/partners/lifi.ts

src/ratesEngine.ts

Clear the timeout when the promise resolves or rejects to prevent the process from hanging due to uncancelled timers.

cursor

Cursor Bugbot has reviewed your changes and found 4 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-01-27T20:28:19Z

src/ratesEngine.ts

+    body: JSON.stringify(ratesRequest)
+  })
+  const ratesResponseJson = await ratesResponse.json()
+  const rates = asRatesV3Params(ratesResponseJson)


Missing HTTP response validation in V3 rates fetch

Medium Severity

The new updateTxValuesV3 function fetches rates from the V3 API but doesn't check ratesResponse.ok before parsing the response. Unlike the existing V2 getExchangeRate function (lines 379-386) which properly checks for HTTP errors and logs rate limiting, the V3 function proceeds directly to ratesResponse.json() and asRatesV3Params(). When the API returns an error (4xx, 5xx), this produces unhelpful cleaner errors instead of the actual API error message, and rate limiting goes undetected.

cursor · 2026-01-27T20:28:19Z

src/partners/lifi.ts

  transfers: asArray(asUnknown)
 })

+type Transfer = ReturnType<typeof asTransfer>


Unused type definition never referenced

Low Severity

The type Transfer is defined as ReturnType<typeof asTransfer> but is never used anywhere in the file. This is dead code that clutters the codebase and may confuse future developers who expect it to be used.

cursor · 2026-01-27T20:28:19Z

src/partners/lifi.ts

+    tx.sending.gasToken?.symbol ??
+    depositToken?.coinKey ??
+    depositToken?.symbol
+  const payoutChainCodeUnmappped =


Typo in variable name with extra letter

Low Severity

The variable payoutChainCodeUnmappped has three 'p's in "Unmapped" instead of two. This is inconsistent with the correctly spelled depositChainCodeUnmapped variable. While functional, this typo makes the code harder to read and search for.

Additional Locations (1)

src/partners/lifi.ts#L198-L200

cursor · 2026-01-27T20:28:19Z

src/partners/lifi.ts

+      : payoutEvmChainId
+
+  const depositTokenType = tokenTypes[depositChainPluginId ?? '']
+  const payoutTokenType = tokenTypes[payoutChainPluginId ?? '']


Unnecessary null coalescing after null guard

Low Severity

Lines 252, 256, 259, and 260 use ?? '' null coalescing on depositChainPluginId and payoutChainPluginId, but these variables are guaranteed to be non-null at this point because lines 244-246 throw an error if either is null. The fallback values can never be reached, making the ?? '' patterns unnecessary.

paullinator added 2 commits July 18, 2025 00:03

Fix hang due to undefined apiKey

e40dcd5

Require couchUris

c0091ec

paullinator force-pushed the paul/v3RatesAndFixes branch from 9b55194 to f9c86ae Compare November 20, 2025 20:56

paullinator force-pushed the paul/v3RatesAndFixes branch from f9c86ae to 1932ac3 Compare December 6, 2025 19:27

samholmes requested changes Jan 7, 2026

View reviewed changes

paullinator added 9 commits January 26, 2026 10:16

fixup! Require couchUris

0ade0d0

Fix moonpay

cf1f99a

Add revolut

Use v2 rates api

d34cf0d

Add index for orderId

8422f1c

Rename yarn scripts to use '.'

5befdec

Properly exit destroyPartition

2ae6594

Add chainId, pluginId, and tokenId fields to StandardTx

dc2a912

Have all plugins just set to undefined for now

Update lifi to provide chainId, pluginId, and tokenId

a1fd398

fixup! Update lifi to provide chainId, pluginId, and tokenId

3b85371

paullinator force-pushed the paul/v3RatesAndFixes branch from 1932ac3 to 6de5280 Compare January 26, 2026 18:23

cursor bot reviewed Jan 26, 2026

View reviewed changes

paullinator added 6 commits January 26, 2026 12:30

fixup! Update lifi to provide chainId, pluginId, and tokenId

4438280

Use ratex v3 if transactions has full pluginId/tokenId values

05ff104

fixup! Use ratex v3 if transactions has full pluginId/tokenId values

42413d3

fixup! Use ratex v3 if transactions has full pluginId/tokenId values

0a12feb

Fix banxa by adding ACH payment type

141712f

Fix promiseTimeout to cleanup setTimeout

579527a

Clear the timeout when the promise resolves or rejects to prevent the process from hanging due to uncancelled timers.

paullinator force-pushed the paul/v3RatesAndFixes branch from 6de5280 to 579527a Compare January 27, 2026 20:19

cursor bot reviewed Jan 27, 2026

View reviewed changes

Plugin ID	Token Support Details
eos	Has customTokenTemplate - supports custom tokens via contract address
telos	Has customTokenTemplate - supports custom tokens via contract address
wax	Has customTokenTemplate - supports custom tokens via contract address
filecoin	Has customTokenTemplate - supports custom tokens via contract address
zano	Has builtinTokens (TALLY, BTCx) and customTokenTemplate for Asset IDs

Conversation

paullinator commented Nov 20, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CHANGELOG

Dependencies

Description

Uh oh!

Choose a reason for hiding this comment

Optional

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 26, 2026

Choose a reason for hiding this comment

Moonpay mobile_wallet case now throws instead of returning null

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 27, 2026

Choose a reason for hiding this comment

Missing HTTP response validation in V3 rates fetch

Uh oh!

cursor bot Jan 27, 2026

Choose a reason for hiding this comment

Unused type definition never referenced

Uh oh!

cursor bot Jan 27, 2026

Choose a reason for hiding this comment

Typo in variable name with extra letter

Uh oh!

cursor bot Jan 27, 2026

Choose a reason for hiding this comment

Unnecessary null coalescing after null guard

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

paullinator commented Nov 20, 2025 •

edited by cursor bot

Loading