Open
Conversation
| const stateFieldLabel = | ||
| countryCode === 'US' | ||
| ? lstrings.form_field_title_address_state | ||
| : lstrings.form_field_title_address_state_province_region |
There was a problem hiding this comment.
Bug: Missing Localized String for State Field
The code uses lstrings.form_field_title_address_state for US users, but this string key only exists in English locale files (en_US.ts and enUS.json). When a US user accesses this form with a non-English language setting, the string key will be undefined in those locale files (e.g., de.json, es.json), causing the field label to display as undefined or cause an error. The string key needs to be added to all supported locale files, or a fallback should be implemented.
swansontec
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Dynamically labels the KYC state field as "State" for US users (using Redux country code) and adds the corresponding locale string.
statefield label based onstate.ui.settings.countryCode(US=>lstrings.form_field_title_address_state, otherwiselstrings.form_field_title_address_state_province_region).useSelectorto read the country code; updates fieldlabelaccordingly.enstringform_field_title_address_state: "State".Written by Cursor Bugbot for commit eec9c1d. This will update automatically on new commits. Configure here.