Enable Rango Exchange swap plugin#4984
Open
Ikari-Shinji-re wants to merge 1 commit intoEdgeApp:developfrom
Open
Enable Rango Exchange swap plugin#4984Ikari-Shinji-re wants to merge 1 commit intoEdgeApp:developfrom
Ikari-Shinji-re wants to merge 1 commit intoEdgeApp:developfrom
Conversation
2 tasks
paullinator
requested changes
Jun 1, 2024
| { | ||
| givenName: 'Rango Exchange', | ||
| hasThumbnail: true, | ||
| thumbnailPath: 'rango.png', |
Member
There was a problem hiding this comment.
Please submit this png to us as part of the PR in the PR comments. It should be square 256x256 or 512x512 png with transparent background
Contributor
Author
There was a problem hiding this comment.
Here is the icon:
https://rango.exchange/logo512.png
| RANGO_INIT: asCorePluginInit( | ||
| asObject({ | ||
| appId: asOptional(asString, 'edge'), | ||
| rangoApiKey: asOptional(asString, ''), |
Member
There was a problem hiding this comment.
please send apikey over Discord
Contributor
Author
There was a problem hiding this comment.
AFAIK , it's already sent to you by Martin.
| appId: asOptional(asString, 'edge'), | ||
| rangoApiKey: asOptional(asString, ''), | ||
| referrerAddress: asOptional(asString, ''), | ||
| referrerFee: asOptional(asString, '0.5') |
Contributor
Author
There was a problem hiding this comment.
It seems you have already changed it in the other PR.
| asObject({ | ||
| appId: asOptional(asString, 'edge'), | ||
| rangoApiKey: asOptional(asString, ''), | ||
| referrerAddress: asOptional(asString, ''), |
Member
There was a problem hiding this comment.
What type of address is this?
Contributor
Author
There was a problem hiding this comment.
It should be an EVM wallet address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-exchange-plugins#322
Requirements
Rango Exchange logo:
https://github.com/rango-exchange/assets/blob/main/branding/icons/icon.png
If you have made any visual changes to the GUI. Make sure you have: