Enable telemetry if cookies are accepted #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirgoldbird
commented
Jan 20, 2026
leoncheng57
requested changes
Jan 20, 2026
Comment on lines
+152
to
+158
| // Suppress CORS errors in local development | ||
| const isLocalhost = window.location.hostname === 'localhost' || window.location.hostname === '127.0.0.1'; | ||
| if (isLocalhost) { | ||
| console.log('[Analytics] Skipping analytics in local development (CORS restriction)'); | ||
| } else { | ||
| console.error('[Analytics] Fetch error: ', error); | ||
| } |
Member
There was a problem hiding this comment.
Why do we need to suppress CORS errors in local development?
Comment on lines
+398
to
+403
| // Skip analytics in local development to avoid CORS errors | ||
| const isLocalhost = window.location.hostname === 'localhost' || window.location.hostname === '127.0.0.1'; | ||
| if (isLocalhost) { | ||
| console.log('[Analytics] Skipping analytics in local development environment.'); | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
I would argue it's preferred to have CORS errors in local development (and use appropriate workarounds) so that these errors don't get uncaught and show up in prod.
| const consent = localStorage.getItem('deepl_cookie_consent'); | ||
|
|
||
| // Only hide banner if user has explicitly accepted or rejected | ||
| if (consent === 'accepted' || consent === 'rejected') return; |
Member
There was a problem hiding this comment.
These should be global variables, not magic strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable us to collect additional insights on our docs if users opt-in to cookies.