Conversation
|
I'm not sure what impact this will have on the 'complete name' since I'm not using that piece of the code. (adafruit_ble creates the name separately). |
|
This should do the job in one line: I need to check into the effect on pack_advertisement() for the complete name, as you pointed out, before committing. Appreciate the bug report though! |
|
The one-liner reduces the file size but uses more CPU and RAM to encode twice. I'm not sure which is more important on a tiny microcontroller but my gut says my version is better. I could shorten the variable name to |
|
I was assuming some sort of compiler optimization would kick in and say, "I've seen |
fixes #17
Length should be encoded without the object ID, according to https://bthome.io/format/