Skip to content

Conversation

@sabrenner
Copy link
Contributor

Motivation

Re-enabling anthropic tests so they run in dd-trace-js CI successfully.

The issue and reason for skipping these tests is two-fold:

  1. The most recent release of @anthropic-ai/sdk starts requiring zod in hot paths (ie, just requiring @anthropic-ai/sdk) without making it a required dependency. Hence, trying to just install the package and requiring it does not work, even in a local reproduction.
  2. Because we were not setting FRAMEWORK_VERSION as a build arg for this app's Dockerfile, we were instead using latest, hitting the error above. Making sure we actually use the pinned (and working) version is good for now.

I didn't include a "fix" for correctly installing zod since it's not needed for now. In the future, maybe we should have safeguards for this. At the same time, this is an odd scenario.

Changes

Includes a forgotten FRAMEWORK_VERSION build arg (these are in Python, but I missed them for Node.js).

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
utils/build/docker/nodejs/anthropic-js.Dockerfile                       @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/nodejs/google_genai-js.Dockerfile                    @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/nodejs/openai-js.Dockerfile                          @DataDog/dd-trace-js @DataDog/system-tests-core

@sabrenner sabrenner marked this pull request as ready for review January 29, 2026 20:20
@sabrenner sabrenner requested review from a team as code owners January 29, 2026 20:20
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 30, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 922f3c9 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants