Skip to content

Conversation

@OliviaShoup
Copy link
Contributor

@OliviaShoup OliviaShoup commented Jan 26, 2026

What does this PR do? What is the motivation?

This PR:

  • adds a new page for Python expressions in Workflow Automation.
  • splits the JavaScript Expressions page in Workflow Automation into a tabbed page for both JavaScript and Python expressions.
  • removes outdated information about expressions.

Merge instructions

Merge readiness:

  • Ready for merge

@OliviaShoup OliviaShoup added the Do Not Merge Just do not merge this PR :) label Jan 26, 2026
@OliviaShoup OliviaShoup requested review from a team as code owners January 26, 2026 21:43
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jan 26, 2026
@OliviaShoup OliviaShoup changed the title (Actions) Add Python expressions support (Actions) Add Python expressions support for workflow automation Jan 26, 2026
@OliviaShoup OliviaShoup added WORK IN PROGRESS No review needed, it's a wip ;) and removed Architecture Everything related to the Doc backend Do Not Merge Just do not merge this PR :) labels Jan 27, 2026
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jan 27, 2026
Copy link
Contributor

@merchristK merchristK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thks for doing this

Comment on lines +14 to +18
• Python version: 3.12.8
• Available libraries: In addition to the Python standard library, the following packages are available:
– rsa (version 4.9)
– python-dateutil (version 2.8.2)
• Network access: Restricted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not render well in the doc. I'd do this:

Suggested change
• Python version: 3.12.8
• Available libraries: In addition to the Python standard library, the following packages are available:
– rsa (version 4.9)
– python-dateutil (version 2.8.2)
• Network access: Restricted
- Python version: 3.12.8
- Available libraries: In addition to the Python standard library, the following packages are available:
- `rsa` (version 4.9)
- `python-dateutil` (version 2.8.2)
- Network access: Restricted

Example structure:

```python
from execution_context import Context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a new line after import

Suggested change
from execution_context import Context
from execution_context import Context

return f"Running workflow {workflow_name!r}"
```

The ctx object provides access to all workflow context variables, similar to the `$` variable in JavaScript expressions. Use dictionary-style access (for example, `ctx["Steps"]["Step_name"]["variable"]`) to reference values from previous steps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The ctx object provides access to all workflow context variables, similar to the `$` variable in JavaScript expressions. Use dictionary-style access (for example, `ctx["Steps"]["Step_name"]["variable"]`) to reference values from previous steps.
The `ctx` object provides access to all workflow context variables, similar to the `$` variable in JavaScript expressions. Use dictionary-style access (for example, `ctx["Steps"]["Step_name"]["variable"]`) to reference values from previous steps.

{{ end }}
</div>
</div>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: file should end with new line

<div class="container cards-dd">
<div class="row row-cols-2 row-cols-sm-3 g-3 justify-content-center">
<div class="col">
<a class="card h-100" href="javascript">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cards feels a bit big and less nice in the doc. Wondering if we could have something shorter. The main issue is that because the cards are large, the icons displayed inside are kinda blurry.

Also on hover, the shadow seems a bit overwhelming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend WORK IN PROGRESS No review needed, it's a wip ;)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants