-
Notifications
You must be signed in to change notification settings - Fork 1.3k
(Actions) Add Python expressions support for workflow automation #34148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
(Actions) Add Python expressions support for workflow automation #34148
Conversation
merchristK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thks for doing this
| • Python version: 3.12.8 | ||
| • Available libraries: In addition to the Python standard library, the following packages are available: | ||
| – rsa (version 4.9) | ||
| – python-dateutil (version 2.8.2) | ||
| • Network access: Restricted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not render well in the doc. I'd do this:
| • Python version: 3.12.8 | |
| • Available libraries: In addition to the Python standard library, the following packages are available: | |
| – rsa (version 4.9) | |
| – python-dateutil (version 2.8.2) | |
| • Network access: Restricted | |
| - Python version: 3.12.8 | |
| - Available libraries: In addition to the Python standard library, the following packages are available: | |
| - `rsa` (version 4.9) | |
| - `python-dateutil` (version 2.8.2) | |
| - Network access: Restricted |
| Example structure: | ||
|
|
||
| ```python | ||
| from execution_context import Context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a new line after import
| from execution_context import Context | |
| from execution_context import Context | |
| return f"Running workflow {workflow_name!r}" | ||
| ``` | ||
|
|
||
| The ctx object provides access to all workflow context variables, similar to the `$` variable in JavaScript expressions. Use dictionary-style access (for example, `ctx["Steps"]["Step_name"]["variable"]`) to reference values from previous steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The ctx object provides access to all workflow context variables, similar to the `$` variable in JavaScript expressions. Use dictionary-style access (for example, `ctx["Steps"]["Step_name"]["variable"]`) to reference values from previous steps. | |
| The `ctx` object provides access to all workflow context variables, similar to the `$` variable in JavaScript expressions. Use dictionary-style access (for example, `ctx["Steps"]["Step_name"]["variable"]`) to reference values from previous steps. |
| {{ end }} | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: file should end with new line
| <div class="container cards-dd"> | ||
| <div class="row row-cols-2 row-cols-sm-3 g-3 justify-content-center"> | ||
| <div class="col"> | ||
| <a class="card h-100" href="javascript"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These cards feels a bit big and less nice in the doc. Wondering if we could have something shorter. The main issue is that because the cards are large, the icons displayed inside are kinda blurry.
Also on hover, the shadow seems a bit overwhelming.
What does this PR do? What is the motivation?
This PR:
Merge instructions
Merge readiness: