-
Notifications
You must be signed in to change notification settings - Fork 1.3k
document metrics support in rust, php, go (cdocs format) #34129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reverts commit cebe0ba.
Content consolidated into the combined api_support.mdoc.md document. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Preview links (active after the
|
buraizu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, approving with some (mostly) optional minor feedback
| {% if equals($prog_lang, "ruby") %} | ||
| - Verify required gems are installed. Ensure `opentelemetry-metrics-sdk` and `opentelemetry-exporter-otlp-metrics` are installed in your Ruby environment. | ||
| - Ensure `Datadog.configure` is called before `OpenTelemetry::SDK.configure`. The Datadog SDK must be configured first to properly set up the meter provider. | ||
| - Verify required gems are installed. Verify `opentelemetry-metrics-sdk` and `opentelemetry-exporter-otlp-metrics` are installed in your Ruby environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Verify required gems are installed. Verify `opentelemetry-metrics-sdk` and `opentelemetry-exporter-otlp-metrics` are installed in your Ruby environment. | |
| - Verify required gems (`opentelemetry-metrics-sdk` and `opentelemetry-exporter-otlp-metrics`) are installed in your Ruby environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion as these sentences seem to have some overlap, feel free to modify the suggestion
| {% if equals($prog_lang, "python") %} | ||
| - Verify `opentelemetry-sdk` is installed. The Python SDK requires `opentelemetry-sdk` and `opentelemetry-exporter-otlp` to be installed in your Python environment. | ||
| - Ensure `ddtrace-run` is active. Verify that you are running your application with `ddtrace-run` (or have imported and initialized `ddtrace` manually). | ||
| - Verify `ddtrace-run` is active. Verify that you are running your application with `ddtrace-run` (or have imported and initialized `ddtrace` manually). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Verify `ddtrace-run` is active. Verify that you are running your application with `ddtrace-run` (or have imported and initialized `ddtrace` manually). | |
| - Verify that you are running your application with `ddtrace-run` (or have imported and initialized `ddtrace` manually). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion as these two sentences seem redundant
| - Enable debug logging with `DD_TRACE_DEBUG=true` to see detailed logs. | ||
| {% /if %} | ||
| {% if equals($prog_lang, "rust") %} | ||
| - Verify transport features are enabled. Verify `metrics-grpc` or `metrics-http` feature is enabled in your Cargo.toml depending on your protocol choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Verify transport features are enabled. Verify `metrics-grpc` or `metrics-http` feature is enabled in your Cargo.toml depending on your protocol choice. | |
| - Verify that a transport feature (`metrics-grpc` or `metrics-http`) is enabled in your Cargo.toml file, depending on your protocol choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional, except for adding file after Cargo.toml.
What does this PR do? What is the motivation?
Takes new content from #33631 and puts it into new cdocs format.
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes