-
Notifications
You must be signed in to change notification settings - Fork 324
Added missing final modifier.
#10430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (317.312 µs) : 267, 368
. : milestone, 317,
basic (272.07 µs) : 265, 279
. : milestone, 272,
loop (8.96 ms) : 8955, 8965
. : milestone, 8960,
section candidate
noprobe (306.818 µs) : 281, 332
. : milestone, 307,
basic (269.909 µs) : 264, 276
. : milestone, 270,
loop (8.951 ms) : 8947, 8955
. : milestone, 8951,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~a3204817f1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083711
Total [baseline] (10.729 s) : 0, 10728618
Agent [candidate] (1.086 s) : 0, 1085771
Total [candidate] (10.894 s) : 0, 10894162
section appsec
Agent [baseline] (1.274 s) : 0, 1273594
Total [baseline] (11.122 s) : 0, 11122130
Agent [candidate] (1.264 s) : 0, 1264091
Total [candidate] (11.054 s) : 0, 11053839
section iast
Agent [baseline] (1.226 s) : 0, 1225762
Total [baseline] (11.145 s) : 0, 11144892
Agent [candidate] (1.224 s) : 0, 1223708
Total [candidate] (11.144 s) : 0, 11144390
section profiling
Agent [baseline] (1.202 s) : 0, 1202041
Total [baseline] (10.856 s) : 0, 10855539
Agent [candidate] (1.206 s) : 0, 1206124
Total [candidate] (10.856 s) : 0, 10856387
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~a3204817f1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (650.111 ms) : 0, 650111
BytebuddyAgent [candidate] (651.293 ms) : 0, 651293
GlobalTracer [baseline] (282.991 ms) : 0, 282991
GlobalTracer [candidate] (283.459 ms) : 0, 283459
AppSec [baseline] (32.481 ms) : 0, 32481
AppSec [candidate] (32.559 ms) : 0, 32559
Debugger [baseline] (68.253 ms) : 0, 68253
Debugger [candidate] (68.287 ms) : 0, 68287
Remote Config [baseline] (618.008 µs) : 0, 618
Remote Config [candidate] (620.409 µs) : 0, 620
Telemetry [baseline] (8.77 ms) : 0, 8770
Telemetry [candidate] (8.885 ms) : 0, 8885
Flare Poller [baseline] (3.761 ms) : 0, 3761
Flare Poller [candidate] (3.886 ms) : 0, 3886
section appsec
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (695.618 ms) : 0, 695618
BytebuddyAgent [candidate] (689.072 ms) : 0, 689072
GlobalTracer [baseline] (260.911 ms) : 0, 260911
GlobalTracer [candidate] (259.133 ms) : 0, 259133
AppSec [baseline] (173.638 ms) : 0, 173638
AppSec [candidate] (171.321 ms) : 0, 171321
Debugger [baseline] (67.871 ms) : 0, 67871
Debugger [candidate] (69.522 ms) : 0, 69522
Remote Config [baseline] (784.027 µs) : 0, 784
Remote Config [candidate] (761.662 µs) : 0, 762
Telemetry [baseline] (9.501 ms) : 0, 9501
Telemetry [candidate] (9.433 ms) : 0, 9433
Flare Poller [baseline] (3.754 ms) : 0, 3754
Flare Poller [candidate] (3.778 ms) : 0, 3778
IAST [baseline] (24.711 ms) : 0, 24711
IAST [candidate] (24.399 ms) : 0, 24399
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (792.693 ms) : 0, 792693
BytebuddyAgent [candidate] (791.155 ms) : 0, 791155
GlobalTracer [baseline] (256.746 ms) : 0, 256746
GlobalTracer [candidate] (256.781 ms) : 0, 256781
AppSec [baseline] (33.547 ms) : 0, 33547
AppSec [candidate] (34.938 ms) : 0, 34938
Debugger [baseline] (66.641 ms) : 0, 66641
Debugger [candidate] (64.933 ms) : 0, 64933
Remote Config [baseline] (586.36 µs) : 0, 586
Remote Config [candidate] (568.865 µs) : 0, 569
Telemetry [baseline] (8.463 ms) : 0, 8463
Telemetry [candidate] (8.438 ms) : 0, 8438
Flare Poller [baseline] (3.572 ms) : 0, 3572
Flare Poller [candidate] (3.52 ms) : 0, 3520
IAST [baseline] (26.933 ms) : 0, 26933
IAST [candidate] (26.889 ms) : 0, 26889
section profiling
ProfilingAgent [baseline] (96.716 ms) : 0, 96716
ProfilingAgent [candidate] (97.134 ms) : 0, 97134
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (700.329 ms) : 0, 700329
BytebuddyAgent [candidate] (701.973 ms) : 0, 701973
GlobalTracer [baseline] (221.304 ms) : 0, 221304
GlobalTracer [candidate] (221.836 ms) : 0, 221836
AppSec [baseline] (32.065 ms) : 0, 32065
AppSec [candidate] (32.38 ms) : 0, 32380
Debugger [baseline] (67.457 ms) : 0, 67457
Debugger [candidate] (68.413 ms) : 0, 68413
Remote Config [baseline] (639.631 µs) : 0, 640
Remote Config [candidate] (681.922 µs) : 0, 682
Telemetry [baseline] (8.948 ms) : 0, 8948
Telemetry [candidate] (8.868 ms) : 0, 8868
Flare Poller [baseline] (3.718 ms) : 0, 3718
Flare Poller [candidate] (3.71 ms) : 0, 3710
Profiling [baseline] (97.293 ms) : 0, 97293
Profiling [candidate] (97.715 ms) : 0, 97715
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~a3204817f1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084770
Total [baseline] (8.757 s) : 0, 8756551
Agent [candidate] (1.093 s) : 0, 1093367
Total [candidate] (8.781 s) : 0, 8781118
section iast
Agent [baseline] (1.224 s) : 0, 1223985
Total [baseline] (9.304 s) : 0, 9303875
Agent [candidate] (1.224 s) : 0, 1224386
Total [candidate] (9.316 s) : 0, 9315889
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~a3204817f1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (651.596 ms) : 0, 651596
BytebuddyAgent [candidate] (657.185 ms) : 0, 657185
GlobalTracer [baseline] (283.297 ms) : 0, 283297
GlobalTracer [candidate] (285.577 ms) : 0, 285577
AppSec [baseline] (32.563 ms) : 0, 32563
AppSec [candidate] (32.988 ms) : 0, 32988
Debugger [baseline] (66.435 ms) : 0, 66435
Debugger [candidate] (67.443 ms) : 0, 67443
Remote Config [baseline] (634.039 µs) : 0, 634
Remote Config [candidate] (622.066 µs) : 0, 622
Telemetry [baseline] (8.88 ms) : 0, 8880
Telemetry [candidate] (8.783 ms) : 0, 8783
Flare Poller [baseline] (4.606 ms) : 0, 4606
Flare Poller [candidate] (3.859 ms) : 0, 3859
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (792.361 ms) : 0, 792361
BytebuddyAgent [candidate] (792.142 ms) : 0, 792142
GlobalTracer [baseline] (256.788 ms) : 0, 256788
GlobalTracer [candidate] (256.721 ms) : 0, 256721
IAST [baseline] (26.776 ms) : 0, 26776
IAST [candidate] (27.095 ms) : 0, 27095
AppSec [baseline] (33.976 ms) : 0, 33976
AppSec [candidate] (35.151 ms) : 0, 35151
Debugger [baseline] (65.088 ms) : 0, 65088
Debugger [candidate] (64.197 ms) : 0, 64197
Remote Config [baseline] (559.186 µs) : 0, 559
Remote Config [candidate] (577.969 µs) : 0, 578
Telemetry [baseline] (8.382 ms) : 0, 8382
Telemetry [candidate] (8.377 ms) : 0, 8377
Flare Poller [baseline] (3.548 ms) : 0, 3548
Flare Poller [candidate] (3.585 ms) : 0, 3585
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 1 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~a3204817f1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section baseline
no_agent (1.17 ms) : 1158, 1181
. : milestone, 1170,
iast (3.199 ms) : 3157, 3240
. : milestone, 3199,
iast_FULL (5.92 ms) : 5861, 5980
. : milestone, 5920,
iast_GLOBAL (3.583 ms) : 3526, 3640
. : milestone, 3583,
profiling (2.013 ms) : 1995, 2031
. : milestone, 2013,
tracing (1.786 ms) : 1771, 1801
. : milestone, 1786,
section candidate
no_agent (1.174 ms) : 1163, 1186
. : milestone, 1174,
iast (3.09 ms) : 3051, 3128
. : milestone, 3090,
iast_FULL (5.737 ms) : 5680, 5794
. : milestone, 5737,
iast_GLOBAL (3.57 ms) : 3515, 3626
. : milestone, 3570,
profiling (2.03 ms) : 2013, 2047
. : milestone, 2030,
tracing (1.794 ms) : 1778, 1810
. : milestone, 1794,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~a3204817f1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section baseline
no_agent (18.028 ms) : 17843, 18214
. : milestone, 18028,
appsec (18.416 ms) : 18230, 18603
. : milestone, 18416,
code_origins (18.609 ms) : 18424, 18794
. : milestone, 18609,
iast (18.915 ms) : 18721, 19108
. : milestone, 18915,
profiling (18.887 ms) : 18695, 19079
. : milestone, 18887,
tracing (17.562 ms) : 17388, 17737
. : milestone, 17562,
section candidate
no_agent (18.285 ms) : 18097, 18473
. : milestone, 18285,
appsec (19.348 ms) : 19151, 19545
. : milestone, 19348,
code_origins (17.484 ms) : 17310, 17658
. : milestone, 17484,
iast (18.102 ms) : 17922, 18281
. : milestone, 18102,
profiling (18.651 ms) : 18466, 18837
. : milestone, 18651,
tracing (17.77 ms) : 17593, 17947
. : milestone, 17770,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~a3204817f1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.711 ms) : 3492, 3930
. : milestone, 3711,
iast (2.207 ms) : 2142, 2272
. : milestone, 2207,
iast_GLOBAL (2.254 ms) : 2188, 2319
. : milestone, 2254,
profiling (2.047 ms) : 1994, 2099
. : milestone, 2047,
tracing (2.041 ms) : 1990, 2093
. : milestone, 2041,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.725 ms) : 3504, 3945
. : milestone, 3725,
iast (2.203 ms) : 2138, 2268
. : milestone, 2203,
iast_GLOBAL (2.256 ms) : 2191, 2322
. : milestone, 2256,
profiling (2.464 ms) : 2304, 2623
. : milestone, 2464,
tracing (2.043 ms) : 1992, 2095
. : milestone, 2043,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~a3204817f1, baseline=1.59.0-SNAPSHOT~6f47da29ddf
dateFormat X
axisFormat %s
section baseline
no_agent (15.516 s) : 15516000, 15516000
. : milestone, 15516000,
appsec (14.826 s) : 14826000, 14826000
. : milestone, 14826000,
iast (18.196 s) : 18196000, 18196000
. : milestone, 18196000,
iast_GLOBAL (18.063 s) : 18063000, 18063000
. : milestone, 18063000,
profiling (14.696 s) : 14696000, 14696000
. : milestone, 14696000,
tracing (14.82 s) : 14820000, 14820000
. : milestone, 14820000,
section candidate
no_agent (14.734 s) : 14734000, 14734000
. : milestone, 14734000,
appsec (14.76 s) : 14760000, 14760000
. : milestone, 14760000,
iast (18.314 s) : 18314000, 18314000
. : milestone, 18314000,
iast_GLOBAL (17.785 s) : 17785000, 17785000
. : milestone, 17785000,
profiling (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
tracing (14.814 s) : 14814000, 14814000
. : milestone, 14814000,
|
jpbempel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix the exploration tests later. You can go and force merge
What Does This Do
Minor code cleanup.
Motivation
Clean code.
Additional Notes
Found by IDEA static analysis.