-
Notifications
You must be signed in to change notification settings - Fork 54
FFL-900 Addresing feature/flags PR feedback
#1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yugisu-flux
wants to merge
1
commit into
feature/flags
Choose a base branch
from
dima/address-feature-flags-pr-feedback
base: feature/flags
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| # Datadog OpenFeature Provider for React Native | ||||||
|
|
||||||
| Use [OpenFeature][1] with [Datadog Feature Flags][2] to evaluate feature flags and send flag evaluation data to Datadog for monitoring analysis and experimentation. | ||||||
| Use [OpenFeature][1] with [Datadog Feature Flags][2] to evaluate feature flags and send evaluation data to Datadog for analysis and experimentation. | ||||||
|
|
||||||
| This package provides an OpenFeature-compatible provider that wraps Datadog's Feature Flags SDK. | ||||||
|
|
||||||
|
|
@@ -10,7 +10,7 @@ OpenFeature is a vendor-neutral, community-driven specification and SDK for feat | |||||
|
|
||||||
| ## Setup | ||||||
|
|
||||||
| **Note**: This package is an integration for the [OpenFeature React SDK][1]. Before using it, install and set up the core [`mobile-react-native`][3] SDK. | ||||||
| **Note**: This package is an integration for the [OpenFeature React SDK][1]. Before starting using Datadog Feature Flags, install and set up the core [`@datadog/mobile-react-native`][3] SDK. | ||||||
|
|
||||||
| To install with NPM, run: | ||||||
|
|
||||||
|
|
@@ -30,8 +30,6 @@ yarn add @datadog/mobile-react-native @datadog/mobile-react-native-openfeature @ | |||||
|
|
||||||
| Use the example code snippet below to initialize the Datadog SDK, enable the Feature Flags feature, and set up the OpenFeature provider. | ||||||
|
|
||||||
| After completing this setup, your app should be ready for flag evaluation with OpenFeature. | ||||||
|
|
||||||
| ```tsx | ||||||
| import { CoreConfiguration, DatadogProvider, DdFlags } from '@datadog/mobile-react-native'; | ||||||
| import { DatadogOpenFeatureProvider } from '@datadog/mobile-react-native-openfeature'; | ||||||
|
|
@@ -67,6 +65,8 @@ import { OpenFeature } from '@openfeature/react-sdk'; | |||||
| </DatadogProvider> | ||||||
| ``` | ||||||
|
|
||||||
| After completing this setup, your app should be ready for flag evaluation with OpenFeature. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| > **Note**: Sending flag evaluation data to Datadog is automatically enabled when using the Feature Flags SDK. Provide `rumIntegrationEnabled` and `trackExposures` parameters to the `DdFlags.enable()` call to configure this. | ||||||
|
|
||||||
| ### Using the OpenFeature React SDK | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.