[CHORE][iOS] Fix Session Replay Text Extraction on RN 0.84 #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbarrio
changed the title
sbarrio
commented
Jan 28, 2026
|
|
||
| internal let uiManager: RCTUIManager | ||
| internal let fabricWrapper: RCTFabricWrapper | ||
| private let textExtractor: RCTTextExtractor |
Contributor
Author
There was a problem hiding this comment.
We don't need it at the moment, but this could be easily extracted to be initialized by a new paramter passed to RCTTextViewRecorder.
cdn34dd
reviewed
Jan 28, 2026
Comment on lines
-59
to
-125
| internal func tryToExtractTextFromSubViews( | ||
| subviews: [RCTShadowView]? | ||
| ) -> String? { | ||
| guard let subviews = subviews else { | ||
| return nil | ||
| } | ||
|
|
||
| return subviews.compactMap { subview in | ||
| if let sub = subview as? RCTRawTextShadowView { | ||
| return sub.text | ||
| } | ||
| if let sub = subview as? RCTVirtualTextShadowView { | ||
| // We recursively get all subviews for nested Text components | ||
| return tryToExtractTextFromSubViews(subviews: sub.reactSubviews()) | ||
| } | ||
| return nil | ||
| }.joined() | ||
| } | ||
|
|
||
| private func tryToExtractTextProperties(view: UIView) -> RCTTextPropertiesWrapper? { | ||
| guard let textView = view as? RCTTextView else { | ||
| return nil | ||
| } | ||
|
|
||
| var shadowView: RCTTextShadowView? = nil | ||
| let tag = textView.reactTag | ||
|
|
||
| let timeout: TimeInterval = 0.2 | ||
| let semaphore = DispatchSemaphore(value: 0) | ||
|
|
||
| // We need to access the shadow view from the UIManager queue, but we're currently on the main thread. | ||
| // Calling `.sync` from the main thread to the UIManager queue is unsafe, because the UIManager queue | ||
| // may already be executing a layout operation that in turn requires the main thread (e.g. measuring a native view). | ||
| // That would create a circular dependency and deadlock the app. | ||
| // To avoid this, we dispatch the work asynchronously to the UIManager queue and wait with a timeout. | ||
| // This ensures we block only if absolutely necessary, and can fail gracefully if the queue is busy. | ||
| RCTGetUIManagerQueue().async { | ||
| shadowView = self.uiManager.shadowView(forReactTag: tag) as? RCTTextShadowView | ||
| semaphore.signal() | ||
| } | ||
|
|
||
| let waitResult = semaphore.wait(timeout: .now() + timeout) | ||
| if waitResult == .timedOut { | ||
| return nil | ||
| } | ||
|
|
||
| guard let shadow = shadowView else { | ||
| return nil | ||
| } | ||
|
|
||
| let textProperties = RCTTextPropertiesWrapper() | ||
|
|
||
| // TODO: RUM-2173 check performance is ok | ||
| if let text = tryToExtractTextFromSubViews(subviews: shadow.reactSubviews()) { | ||
| textProperties.text = text | ||
| } | ||
|
|
||
| if let foregroundColor = shadow.textAttributes.foregroundColor { | ||
| textProperties.foregroundColor = foregroundColor | ||
| } | ||
|
|
||
| textProperties.alignment = shadow.textAttributes.alignment | ||
| textProperties.fontSize = shadow.textAttributes.fontSize | ||
| textProperties.contentRect = shadow.contentFrame | ||
|
|
||
| return textProperties | ||
| } |
Contributor
There was a problem hiding this comment.
I'm not against extracting this logic outside of this class but I don't think we should remove the swift code, would this not work ?
// RCTHelper.h
#import <Foundation/Foundation.h>
@interface RCTHelper : NSObject
+ (BOOL)isNewArchEnabled;
@end
#import "RCTHelper.h"
@implementation RCTHelper
+ (BOOL)isNewArchEnabled {
#if RCT_NEW_ARCH_ENABLED
return YES;
#else
return NO;
#endif
}
@end
then in swfit:
let isNewArchEnabled = RCTHelper.isNewArchEnabled()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR solves a build issue with React Native 0.84 that affects Session Replay recording on iOS.
Our RCTTextViewRecorder relied on
RCTTextView,RCTShadowView,RCTRawTextShadowViewandRCTVirtualTextShadowViewbeing available both on new and old architecture. Since 0.84 removes them on new architecture we can no longer use them on the text property extraction code, as it will create an error at build time.This code now needs to be gatekept by the use of the RCT_NEW_ARCH_ENABLED env variable, and since that value is only available to obj-C files it means that we need to port over our
tryToExtractTextPropertiesto objC.That has been done by creating a new class,
RCTTextExtractor, which now encapsulates this logic and properly adapts both to new and old architectures. Tests have been adapted accordingly too.Motivation
We should support never versions of React Native seamlessly.
Additional Notes
Review checklist (to be filled by reviewers)