-
Notifications
You must be signed in to change notification settings - Fork 53
FFL-900 Flags SDK #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
FFL-900 Flags SDK #1092
Conversation
…plement-flags-react-native-ios-wrapper
…-implement-flags-react-native-open-feature-provider
[CHORE] Update `feature/flags` with latest `develop`
…-implement-flags-react-native-open-feature-provider
…act-native-open-feature-provider FFL-908 Implement Flags OpenFeature provider for React Native
| s.dependency 'DatadogTrace', '3.4.0' | ||
| s.dependency 'DatadogRUM', '3.4.0' | ||
| s.dependency 'DatadogCrashReporting', '3.4.0' | ||
| s.dependency 'DatadogCore', '3.5.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native Datadog SDKs are bumped to 3.5.0.
maycmlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions
| @@ -0,0 +1,119 @@ | |||
| # Datadog OpenFeature Provider for React Native | |||
|
|
|||
| Use [OpenFeature][1] with [Datadog Feature Flags][2] to evaluate feature flags and send flag evaluation data to Datadog for monitoring analysis and experimentation. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Use [OpenFeature][1] with [Datadog Feature Flags][2] to evaluate feature flags and send flag evaluation data to Datadog for monitoring analysis and experimentation. | |
| Use [OpenFeature][1] with [Datadog Feature Flags][2] to evaluate feature flags and send evaluation data to Datadog to monitor analysis and experimentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
|
||
| ## Setup | ||
|
|
||
| **Note**: This package is an integration for the [OpenFeature React SDK][1]. Before using it, install and set up the core [`mobile-react-native`][3] SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
| **Note**: This package is an integration for the [OpenFeature React SDK][1]. Before using it, install and set up the core [`mobile-react-native`][3] SDK. | |
| **Note**: This package is an integration for the [OpenFeature React SDK][1]. Before using the integration, install and set up the core [`mobile-react-native`][3] SDK. |
|
|
||
| Use the example code snippet below to initialize the Datadog SDK, enable the Feature Flags feature, and set up the OpenFeature provider. | ||
|
|
||
| After completing this setup, your app should be ready for flag evaluation with OpenFeature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this should be moved to after running the code snippet with the following suggested edits:
| After completing this setup, your app should be ready for flag evaluation with OpenFeature. | |
| After completing this setup, your app is ready for flag evaluation with OpenFeature. |
Motivation
The main motivation for these changes is the Datadog Feature Flags SDK fanout initiative.
Related ticket: https://datadoghq.atlassian.net/browse/FFL-900
What does this PR do?
This PR adds Datadog Feature Flags to the Datadog React Native SDK.
DdFlagsare added to the SDK core, and a public-facing interface of this feature is exported from the@datadog/mobile-react-native-openfeaturepackage in a form of an OpenFeature-compatible provider.This new RN SDK brings full feature parity with native iOS and Android implementations of Flags, wrapping them with a JS layer aiming to be as thin as possible.
This PR is a collective result of the following PRs. For more details on individual implementation steps, please consult with them:
Additional Notes
This SDK has been implemented following the requirements stated in internal documents:
Review checklist (to be filled by reviewers)