Fix loss of precision with BigDateTime#219
Open
lanfeust69 wants to merge 1 commit intoDataAction:masterfrom
Open
Fix loss of precision with BigDateTime#219lanfeust69 wants to merge 1 commit intoDataAction:masterfrom
lanfeust69 wants to merge 1 commit intoDataAction:masterfrom
Conversation
We should ensure as much as possible a correct round-trip with DateTime. Since DateTime has a higher precision (1/10 µs instead of 1 µs), this is the limit, but we can avoid truncating microseconds.
zoechelvaraj
approved these changes
Dec 16, 2021
|
Hello @zoechelvaraj is this project still maintained ? I see that you accepted this PR a year ago but it's still waiting to be merged |
|
Indeed, I'd like to see this PR merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should ensure as much as possible a correct round-trip with DateTime.
Since DateTime has a higher precision (1/10 µs instead of 1 µs), this is
the limit, but we can avoid truncating microseconds.