Openrgb device updated implementation#338
Open
Aytackydln wants to merge 6 commits intoDarthAffe:Developmentfrom
Open
Openrgb device updated implementation#338Aytackydln wants to merge 6 commits intoDarthAffe:Developmentfrom
Aytackydln wants to merge 6 commits intoDarthAffe:Developmentfrom
Conversation
Contributor
Author
|
I added naming changes when DeviceId doesn't exist, for example with fans. Same change with common commit is also in OpenRGB PR |
…to openrgb-device-updated # Conflicts: # RGB.NET.Devices.OpenRGB/OpenRGBDeviceProvider.cs
…to openrgb-device-updated # Conflicts: # RGB.NET.Core/Ids/IdGenerator.cs # RGB.NET.Devices.OpenRGB/OpenRGBDeviceProvider.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds DevicesChanged implementation for OpenRgb library.
Breaking Changes
Previously device names were created different each time, adding number in a paranthesis in their names. This caused problems when devices were reconnected or while checking if the device is new or not.
My proposal is adding a hash to the Device Names based on serial or device location (for internal devices). For zones and segments, their zone or segment name is also appended and not using incremental numbers in Device Names